ext/date: Deprecate SUNFUNCS_RET_{STRING,DOUBLE,TIMESTAMP} constants

Deprecates constants:
 - SUNFUNCS_RET_STRING
 - SUNFUNCS_RET_TIMESTAMP
 - SUNFUNCS_RET_DOUBLE

They are only used for parameters of date_sun_info() function, which is deprecated
since PHP 8.1

Author: Ayesh

UPGRADING

@@ -278,6 +278,10 @@ PHP 8.4 UPGRADE NOTES
 - Date:
   . Calling DatePeriod::__construct(string $isostr, int $options = 0) is
     deprecated. Use DatePeriod::createFromISO8601String() instead.
+  . SUNFUNCS_RET_STRING, SUNFUNCS_RET_DOUBLE, and SUNFUNCS_RET_TIMESTAMP
+    constants are deprecated. They are only used as parameters to the
+    date_sunrise() and date_sunset() function, which are deprecated
+    since PHP 8.1.
 
 - Intl:
   . Calling intlcal_set() as well as calling IntlCalendar::set() with

ext/date/php_date.stub.php

@@ -83,18 +83,21 @@
 /**
  * @var int
  * @cvalue SUNFUNCS_RET_TIMESTAMP
+ * @deprecated
  */
 const SUNFUNCS_RET_TIMESTAMP = UNKNOWN;
 
 /**
  * @var int
  * @cvalue SUNFUNCS_RET_STRING
+ * @deprecated
  */
 const SUNFUNCS_RET_STRING = UNKNOWN;
 
 /**
  * @var int
  * @cvalue SUNFUNCS_RET_DOUBLE
+ * @deprecated
  */
 const SUNFUNCS_RET_DOUBLE = UNKNOWN;
 

ext/date/php_date_arginfo.h

@@ -25,9 +25,13 @@ var_dump(gettype(date_sunset(time())));
 --EXPECTF--
 Basic test for date_sunrise() and date_sunset()
 
+Deprecated: Constant SUNFUNCS_RET_STRING is deprecated in %s on line %d
+
 Deprecated: Function date_sunrise() is deprecated in %s on line %d
 %s %s %d %d, sunrise time : %d:%d
 
+Deprecated: Constant SUNFUNCS_RET_STRING is deprecated in %s on line %d
+
 Deprecated: Function date_sunset() is deprecated in %s on line %d
 %s %s %d %d, sunset time : %d:%d
 

ext/date/tests/date_sunrise_and_sunset_basic.phpt

@@ -0,0 +1,19 @@
+--TEST--
+SUNFUNCS_RET_STRING, SUNFUNCS_RET_DOUBLE, and SUNFUNCS_RET_TIMESTAMP constants are deprecated
+--FILE--
+<?php
+
+var_dump(SUNFUNCS_RET_STRING);
+var_dump(SUNFUNCS_RET_DOUBLE);
+var_dump(SUNFUNCS_RET_TIMESTAMP);
+
+?>
+--EXPECTF--
+Deprecated: Constant SUNFUNCS_RET_STRING is deprecated in %s on line %d
+int(1)
+
+Deprecated: Constant SUNFUNCS_RET_DOUBLE is deprecated in %s on line %d
+int(2)
+
+Deprecated: Constant SUNFUNCS_RET_TIMESTAMP is deprecated in %s on line %d
+int(0)