Deprecate DATE_RET_* constants (related to date_sunrise/date_sunset)

Related: 5bb83b3
`date_sunrise` and `date_sunset` functions are deprecated in PHP 8.1, along
with the ini settings.

Both `date_sunrise` and `date_sunset` functions accept a parameter to specify
the format of the returned time. They accept one of the three following
constants:

 - `SUNFUNCS_RET_STRING`
 - `SUNFUNCS_RET_DOUBLE`
 - `SUNFUNCS_RET_TIMESTAMP`

These constants are only used with `date_sunrise` and `date_sunset` functions,
and are not used anywhere. This deprecates the three constants.

Author: Ayesh

UPGRADING

@@ -361,7 +361,10 @@ PHP 8.1 UPGRADE NOTES
 
 - Date:
   . The date_sunrise() and date_sunset() functions have been deprecated in
-    favor of date_sun_info().
+    favor of date_sun_info(). Their related ini settings
+    date.default_latitude, date.default_longitude and date.sunset_zenith,
+    along with constants SUNFUNCS_RET_STRING, SUNFUNCS_RET_DOUBLE, and
+    SUNFUNCS_RET_TIMESTAMP are also deprecated.
     RFC: https://wiki.php.net/rfc/deprecations_php_8_1
   . The strftime() and gmstrftime() functions have been deprecated in favor of
     date()/DateTime::format() (for locale-independent formatting) or

ext/date/php_date.c

@@ -413,9 +413,9 @@ PHP_MINIT_FUNCTION(date)
 	REGISTER_STRING_CONSTANT("DATE_RSS",     DATE_FORMAT_RFC1123, CONST_CS | CONST_PERSISTENT);
 	REGISTER_STRING_CONSTANT("DATE_W3C",     DATE_FORMAT_RFC3339, CONST_CS | CONST_PERSISTENT);
 
-	REGISTER_LONG_CONSTANT("SUNFUNCS_RET_TIMESTAMP", SUNFUNCS_RET_TIMESTAMP, CONST_CS | CONST_PERSISTENT);
-	REGISTER_LONG_CONSTANT("SUNFUNCS_RET_STRING", SUNFUNCS_RET_STRING, CONST_CS | CONST_PERSISTENT);
-	REGISTER_LONG_CONSTANT("SUNFUNCS_RET_DOUBLE", SUNFUNCS_RET_DOUBLE, CONST_CS | CONST_PERSISTENT);
+	REGISTER_LONG_CONSTANT("SUNFUNCS_RET_TIMESTAMP", SUNFUNCS_RET_TIMESTAMP, CONST_CS | CONST_PERSISTENT | CONST_DEPRECATED);
+	REGISTER_LONG_CONSTANT("SUNFUNCS_RET_STRING", SUNFUNCS_RET_STRING, CONST_CS | CONST_PERSISTENT | CONST_DEPRECATED);
+	REGISTER_LONG_CONSTANT("SUNFUNCS_RET_DOUBLE", SUNFUNCS_RET_DOUBLE, CONST_CS | CONST_PERSISTENT | CONST_DEPRECATED);
 
 	php_date_global_timezone_db = NULL;
 	php_date_global_timezone_db_enabled = 0;

ext/date/tests/date_sunrise_and_sunset_basic.phpt

@@ -25,9 +25,11 @@ var_dump(gettype(date_sunset(time())));
 --EXPECTF--
 Basic test for date_sunrise() and date_sunset()
 
+Deprecated: Constant SUNFUNCS_RET_STRING is deprecated in %s on line %d
 Deprecated: Function date_sunrise() is deprecated in %s on line %d
 %s %s %d %d, sunrise time : %d:%d
 
+Deprecated: Constant SUNFUNCS_RET_STRING is deprecated in %s on line %d
 Deprecated: Function date_sunset() is deprecated in %s on line %d
 %s %s %d %d, sunset time : %d:%d
 

ext/date/tests/sun_consts_deprecated.phpt

@@ -0,0 +1,19 @@
+--TEST--
+SUNFUNCS_RET_STRING, SUNFUNCS_RET_DOUBLE, and SUNFUNCS_RET_TIMESTAMP constants are deprecated
+--FILE--
+<?php
+
+var_dump(SUNFUNCS_RET_STRING);
+var_dump(SUNFUNCS_RET_DOUBLE);
+var_dump(SUNFUNCS_RET_TIMESTAMP);
+
+?>
+--EXPECTF--
+Deprecated: Constant SUNFUNCS_RET_STRING is deprecated in %s on line %d
+int(1)
+
+Deprecated: Constant SUNFUNCS_RET_DOUBLE is deprecated in %s on line %d
+int(2)
+
+Deprecated: Constant SUNFUNCS_RET_TIMESTAMP is deprecated in %s on line %d
+int(0)