Add a few types to zend_builtin_functions stub #13636
Conversation
alexandre-daubois
force-pushed
the
zend-stub-types
branch
from
cb6ff32 to
e4b793c
Compare
alexandre-daubois
force-pushed
the
zend-stub-types
branch
from
7b17e1e to
189a625
Compare
| @@ -65,14 +65,12 @@ function get_mangled_object_vars(object $object): array {} | |||
| */ | |||
| function get_class_methods(object|string $object_or_class): array {} | |||
|
|
|||
| /** @param object|string $object_or_class */ | |||
| function method_exists($object_or_class, string $method): bool {} | |||
| function method_exists(object|string $object_or_class, string $method): bool {} | |||
There was a problem hiding this comment.
There were multiple attempts to add these param types but at last we settled on not to add them. See
#11555 (comment) for reasoning.
There was a problem hiding this comment.
Alright, got it 👍
| @@ -107,13 +105,11 @@ function trigger_error(string $message, int $error_level = E_USER_NOTICE): true | |||
| /** @alias trigger_error */ | |||
| function user_error(string $message, int $error_level = E_USER_NOTICE): true {} | |||
|
|
|||
| /** @return callable|null */ | |||
| function set_error_handler(?callable $callback, int $error_levels = E_ALL) {} | |||
| function set_error_handler(?callable $callback, int $error_levels = E_ALL): ?callable {} | |||
There was a problem hiding this comment.
The reason these return types are not documented is described in Nikita's comment: #5618 (review)
There was a problem hiding this comment.
Basically as @kocsismate has already indicated from prior discussion it is not really doable.
However, for set_error_handler/set_exception_handler I can imagine that if we return a Closure instead of just a callable that would solve the scoping issue that Nikita mentioned. But this might break some userland expectations?
|
There's no broken expectation I can see. What could be done in userland is either use |
Inspired by #13614, it seems we can add these return types to stubs?