Add hint-type for method_exists & property_exists

[milwad-dev]

The get_class_methods has a type-hint, but method_exists & property_exists have no type-hint for object_or_class parameters.

[iluuu1994]

@kocsismate What's the reason for using doc types here rather than real parameter types here? ZPP already restricts this to objects and strings.

[kocsismate]

What's the reason for using doc types here rather than real parameter types here? ZPP already restricts this to objects and strings.

Huh, I'm not sure anymore... As far as I remember, I wanted to use Z_PARAM_OBJ_OR_CLASS_NAME first, but we decided not to do it due to the RETURN_FALSE when the class cannot be autoloaded.

And that's all what I remember... object|string should work and we could even use fast ZPP.

[kocsismate]

Ok, I've just found the answer: I already suspected that it may be because of loose vs strict parameter parsing, but George's comment in property_exists() makes the situation 100% clear:

/* We do not use Z_PARAM_OBJ_OR_STR here to be able to exclude int, float, and bool which are bogus class names */

[Girgias]

@kocsismate What's the reason for using doc types here rather than real parameter types here? ZPP already restricts this to objects and strings.

The issue is when the coercive typing mode is used, as booleans, integers, and floating point numbers are going to be converted to string, however we know those are completely wrong as no class would satisfy those sorts of names.

I suppose we could also enhance those functions by adding a check for an empty string, but the zend_lookup_class() kinda takes care of that already.