`hash_update` returns always `true`

[mvorisek]

Description

https://github.com/php/php-src/blob/791ca5d1db/ext/hash/hash.stub.php#L32

maybe there are more return types that can be improved

man: https://www.php.net/manual/en/function.hash-update.php#refsect1-function.hash-update-returnvalues

script to get return types from phpstan: https://3v4l.org/SXRNM/rfc#vgit.master - phpstan types are worse than https://github.com/JetBrains/phpstorm-stubs

[Girgias]

The documentation is not the reference of the language, the documentation reflects the language.

So what the manual says is irrelevant. However, if this function does only ever return true then the stubs should be changed to have a true return type.

[MorganLOCode]

Indeed, the stub for hash_update is five years old; the true return type was only added in 2022.

[nielsdos]

Looking at the implementation, indeed it can only be true

php-src/ext/hash/hash.c

Line 704 in a541b95

RETURN_TRUE;

Feel free to open a PR.

[nielsdos]

I checked the other functions, and only hash_update can be changed. I'll prepare a PR.