Fix sysconf functions in FreeBSD #12995

5u623l20 · 2023-12-21T20:22:03Z

All FreeBSD do not implement the function sysconf with arguments _SC_GETGR_R_SIZE_MAX , _SC_TTY_NAME_MAX:_SC_GETPW_R_SIZE_MAX.

php use this sysconf() in:

main/main.c php_get_current_user()
main/fopen_wrappers.c php_fopen_primary_script()
ext/posix/posix.c posix_getpwnam(), posix_getpwuid(), posix_getgrnam(), posix_getgrgid()
ext/standard/filestat.c php_get_uid_by_name(), php_get_gid_by_name()

All FreeBSD do not implement the function sysconf with arguments _SC_GETGR_R_SIZE_MAX , _SC_GETPW_R_SIZE_MAX. php use this sysconf() in: - main/main.c php_get_current_user() - main/fopen_wrappers.c php_fopen_primary_script() - ext/posix/posix.c posix_getpwnam(), posix_getpwuid(), posix_getgrnam(), posix_getgrgid() - ext/standard/filestat.c php_get_uid_by_name(), php_get_gid_by_name()

bukka

Few questions - please note that they apply on some other parts as they are done in the same way (just commented on the first one)

bukka · 2023-12-21T20:29:37Z

ext/posix/posix.c

@@ -476,6 +476,9 @@ PHP_FUNCTION(posix_ttyname)
 	}
 #if defined(ZTS) && defined(HAVE_TTYNAME_R) && defined(_SC_TTY_NAME_MAX)
 	buflen = sysconf(_SC_TTY_NAME_MAX);


Is _SC_TTY_NAME_MAX also problematic on FreeBSD (you haven't listed it in description...)? If so, is that even defined?

Yes it's defined.
https://cgit.freebsd.org/src/tree/lib/libc/gen/sysconf.c#n445

I have updated the description.

ext/posix/posix.c

bukka · 2023-12-21T20:30:39Z

ext/posix/posix.c

@@ -783,6 +786,9 @@ PHP_FUNCTION(posix_getgrnam)

 #if defined(ZTS) && defined(HAVE_GETGRNAM_R) && defined(_SC_GETGR_R_SIZE_MAX)
 	buflen = sysconf(_SC_GETGR_R_SIZE_MAX);
+#if defined(__FreeBSD__) && defined(_SC_PAGESIZE)


if it's not supported on all FreeBSD, why do you still try to use _SC_GETGR_R_SIZE_MAX and then just fall back?

It's hardcoded as -1.
https://cgit.freebsd.org/src/tree/lib/libc/gen/sysconf.c#n363

I think what bukka meant is why bothering with _SC_GETGR_R_SIZE_MAX if it returns -1 anyway (means no hard limit on the getgrnam_r buffer in theory).

So I looked a bit around, also dragonflybsd and linux/musl returns -1 too, so would checking -1 and no errno set do the trick ?

Give me some times to recheck. At least in one circumstances with FreeBSD 12 I can see that:
<?php var_dump(posix_getpwuid(0)); ?> just returns bool(false) where not on recent FreeBSD versions. I will need to recheck the codebase updates.

So it looks like that when ZTS is enabled this issue occurs returns bool(false). And when ZTS is not enabled this issue does not occur. So setting no errno should resolve the problem.

Sorry I still don't understand why it needs to fail first?

Closing this in lieu of #13187

All FreeBSD do not implement the function sysconf with arguments _SC_GETGR_R_SIZE_MAX , _SC_GETPW_R_SIZE_MAX. php use this sysconf() in: - main/main.c php_get_current_user() - main/fopen_wrappers.c php_fopen_primary_script() - ext/posix/posix.c posix_getpwnam(), posix_getpwuid(), posix_getgrnam(), posix_getgrgid() - ext/standard/filestat.c php_get_uid_by_name(), php_get_gid_by_name()

ext/posix/posix.c

All FreeBSD do not implement the function sysconf with arguments _SC_GETGR_R_SIZE_MAX , _SC_GETPW_R_SIZE_MAX , _SC_TTY_NAME_MAX. php use this sysconf() in: - main/main.c php_get_current_user() - main/fopen_wrappers.c php_fopen_primary_script() - ext/posix/posix.c posix_getpwnam(), posix_getpwuid(), posix_getgrnam(), posix_getgrgid() - ext/standard/filestat.c php_get_uid_by_name(), php_get_gid_by_name()

@rainerjung

…support. fix from @rainerjung

…_FETCHES Partial backport of phpGH-12793. Closes phpGH-12970.

* PHP-8.2: Fix phpGH-12969: Fixed PDO::getAttribute() to get PDO::ATTR_STRINGIFY_FETCHES

* PHP-8.3: Fix phpGH-12969: Fixed PDO::getAttribute() to get PDO::ATTR_STRINGIFY_FETCHES

Autotools emits warning if 3rd argument is empty. Call is wrapped in the AC_CACHE_CHECK with php_cv_* cache variable name according to the docs. Closes phpGH-12966

macOs CI update. since sonoma (14) had been released since few months, we could afford to upgrade to its previous release.

* PHP-8.2: Add cross-compiling 3rd argument to AC_RUN_IFELSE

* PHP-8.3: Add cross-compiling 3rd argument to AC_RUN_IFELSE

…tes" and empty attributes Closes phpGH-12993.

* PHP-8.2: Fix phpGH-12980: tidynode.props.attribute is missing "Boolean Attributes" and empty attributes

* PHP-8.3: Fix phpGH-12980: tidynode.props.attribute is missing "Boolean Attributes" and empty attributes

Close phpGH-12955

* PHP-8.3: Fix crash when toggleAttribute() is used without a document

I forgot to also update the document reference of attributes, so when there is no document reference anymore from a variable, but still an attribute, this can crash. Fix it by also updating the document references for attributes. Closes phpGH-13002.

There's two issues here: - freeing of predefined entity declaration crashes (unique to 8.3 & master) - using multiple entity references for a single entity declaration crashes (since forever) The fix for the last issue is fairly easy to do on 8.3, but may require a slightly different approach on 8.2. Therefore, for now this is 8.3-only. Closes phpGH-13004.

5u623l20 requested a review from bukka as a code owner December 21, 2023 20:22

github-actions bot added Extension: posix Extension: standard labels Dec 21, 2023

bukka reviewed Dec 21, 2023

View reviewed changes

bukka requested a review from devnexen December 21, 2023 20:32

devnexen reviewed Dec 21, 2023

View reviewed changes

ext/posix/posix.c Outdated Show resolved Hide resolved

5u623l20 and others added 21 commits December 21, 2023 22:11

Fix phpGH-12999: zend_strnlen build fix when platform misses strnlen …

a2068ef

…support. fix from @rainerjung

Merge branch 'PHP-8.3'

4ffa6e3

Fix phpGH-12969: Fixed PDO::getAttribute() to get PDO::ATTR_STRINGIFY…

b333164

…_FETCHES Partial backport of phpGH-12793. Closes phpGH-12970.

Merge branch 'PHP-8.2' into PHP-8.3

c3f6579

* PHP-8.2: Fix phpGH-12969: Fixed PDO::getAttribute() to get PDO::ATTR_STRINGIFY_FETCHES

Merge branch 'PHP-8.3'

702fbc8

* PHP-8.3: Fix phpGH-12969: Fixed PDO::getAttribute() to get PDO::ATTR_STRINGIFY_FETCHES

Add cross-compiling 3rd argument to AC_RUN_IFELSE

de5557b

Autotools emits warning if 3rd argument is empty. Call is wrapped in the AC_CACHE_CHECK with php_cv_* cache variable name according to the docs. Closes phpGH-12966

macOs CI update. (php#12998)

952ffbf

macOs CI update. since sonoma (14) had been released since few months, we could afford to upgrade to its previous release.

Merge branch 'PHP-8.2' into PHP-8.3

71e002b

* PHP-8.2: Add cross-compiling 3rd argument to AC_RUN_IFELSE

Merge branch 'PHP-8.3'

907b078

* PHP-8.3: Add cross-compiling 3rd argument to AC_RUN_IFELSE

[skip ci] Update NEWS so it includes only PHP-8.4 relevant changes

08b11e8

Fix phpGH-12980: tidynode.props.attribute is missing "Boolean Attribu…

b3f483d

…tes" and empty attributes Closes phpGH-12993.

Merge branch 'PHP-8.2' into PHP-8.3

b1206ea

* PHP-8.2: Fix phpGH-12980: tidynode.props.attribute is missing "Boolean Attributes" and empty attributes

Merge branch 'PHP-8.3'

ec8e86b

* PHP-8.3: Fix phpGH-12980: tidynode.props.attribute is missing "Boolean Attributes" and empty attributes

phpGH-12943 ext/intl accept C as acceptable locale argument.

6a447e7

Close phpGH-12955

Merge branch 'PHP-8.2' into PHP-8.3

f20edf0

Merge branch 'PHP-8.3'

5455c3f

Fix crash when toggleAttribute() is used without a document

b2d778c

Merge branch 'PHP-8.3'

20dfc41

* PHP-8.3: Fix crash when toggleAttribute() is used without a document

5u623l20 mentioned this pull request Jan 18, 2024

All FreeBSD do not implement the function sysconf with arguments #13187

Open

5u623l20 closed this Jan 18, 2024

5u623l20 deleted the freebsd-posix branch January 18, 2024 09:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix sysconf functions in FreeBSD #12995

Fix sysconf functions in FreeBSD #12995

Uh oh!

5u623l20 commented Dec 21, 2023 •

edited

Loading

Uh oh!

bukka left a comment

Uh oh!

bukka Dec 21, 2023

Uh oh!

5u623l20 Dec 21, 2023

Uh oh!

5u623l20 Dec 21, 2023

Uh oh!

Uh oh!

bukka Dec 21, 2023

Uh oh!

5u623l20 Dec 21, 2023

Uh oh!

devnexen Dec 21, 2023

Uh oh!

devnexen Dec 21, 2023

Uh oh!

5u623l20 Dec 21, 2023

Uh oh!

5u623l20 Dec 23, 2023

Uh oh!

bukka Jan 12, 2024

Uh oh!

5u623l20 Jan 18, 2024

Uh oh!

Uh oh!

Uh oh!

Fix sysconf functions in FreeBSD #12995

Fix sysconf functions in FreeBSD #12995

Uh oh!

Conversation

5u623l20 commented Dec 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bukka left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

5u623l20 commented Dec 21, 2023 •

edited

Loading