Add cross-compiling argument to AC_RUN_IFELSE #12966
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we maybe target here PHP-8.1 or PHP-8.2 branch? |
|
I think backporting this to 8.2 certainly makes sense, since this code is new. |
Autotools emits warning if 3rd argument is empty. Call is wrapped in the AC_CACHE_CHECK with php_cv_* cache variable name according to the docs.
petk
force-pushed
the
patch-autoconf-cross-compile
branch
from
7c15d2b to
bcab663
Compare
|
Merged to PHP-8.2 to future proof Autoconf generation, just in case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autoconf emits a warning if 3rd argument in AC_RUN_IFELSE is empty:
Additionally, call is wrapped in the AC_CACHE_CHECK with php_cv_* cache variable name according to the docs.
Related to #12642