Skip to content

[pdo] Fixed setAttribute and getAttribute #12793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2023
Merged

[pdo] Fixed setAttribute and getAttribute #12793

merged 2 commits into from
Dec 4, 2023

Conversation

SakiTakamachi
Copy link
Member

@SakiTakamachi SakiTakamachi commented Nov 27, 2023 •
edited
Loading

Fixed the types of setAttribute and getAttribute, and added attribute values ​​that can be retrieved with getAttribute.

This pull request does not consider attribute value settings in the constructor. I'll do that in a separate change. Also, obviously strange attribute values ​​(such as PDO_MYSQL_ATTR_DIRECT_QUERY) are not considered. This is because changing or abolishing such attribute values ​​should probably be discussed properly.

Since oci has already been decided to be unbundled, it will not be considered.

todo:

  • add tests (I made some additions to the existing test.)

However, only Firebird lacks testing. Originally, there were no tests for some attribute values ​​at all. Since I also need to confirm how attribute values ​​work, I will not consider Firebird testing in this PR.

@SakiTakamachi SakiTakamachi changed the title [WIP] [pdo] Fix set and get attr [pdo] Fix set and get attr Nov 30, 2023
@SakiTakamachi SakiTakamachi marked this pull request as ready for review November 30, 2023 12:14
@SakiTakamachi
Copy link
Member Author

@Girgias
This is a PR regarding an issue that was briefly discussed in the pdo_odbc pull request.

Girgias
Girgias approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please add a note into UPGRADING/NEWS about what attributes had their type changed just so we don't lose this information. :)

@SakiTakamachi SakiTakamachi changed the title [pdo] Fix set and get attr [pdo] Fixed setAttribute and getAttribute Dec 2, 2023
@SakiTakamachi
Copy link
Member Author

Added to UPGRADING/NEWS!

@Girgias Girgias merged commit 866aa12 into php:master Dec 4, 2023
@SakiTakamachi SakiTakamachi deleted the pdo_attr_fix branch December 5, 2023 02:59
This was referenced Dec 18, 2023
Closed
Closed
nielsdos pushed a commit that referenced this pull request Dec 22, 2023
@SakiTakamachi @nielsdos
Fix GH-12969: Fixed PDO::getAttribute() to get PDO::ATTR_STRINGIFY_FE…
b333164 
…TCHES

Partial backport of GH-12793.

Closes GH-12970.
@nielsdos nielsdos mentioned this pull request Mar 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

@devnexen devnexen Awaiting requested review from devnexen devnexen is a code owner

Assignees
No one assigned
Labels
Extension: pdo (core) Extension: pdo_dblib Extension: pdo_firebird Extension: pdo_mysql Extension: pdo_odbc Extension: pdo_pgsql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SakiTakamachi @Girgias