Skip to content

Introduce keep-a-changelog #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Conversation

boesing
Copy link
Contributor

@boesing boesing commented Apr 4, 2023

This also adds all changes since v1.0.0 to the CHANGELOG

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets none
Documentation none
License MIT

What's in this PR?

This PR adds CHANGELOG for all versions since v1.0.0 as requested in #65 (comment)

This also adds all changes since v1.0.0 to the CHANGELOG

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@dbu
Copy link
Contributor

dbu commented Apr 4, 2023

awesome, thanks!

i only recently started reviewing MRs in the repository, and was not aware we did the changelog differently than in other places. great to get this cleaned up 👍

@dbu dbu merged commit 3867c50 into php-http:master Apr 4, 2023
@boesing boesing deleted the docs/keep-a-changelog branch April 4, 2023 13:57
@boesing
Copy link
Contributor Author

boesing commented Apr 4, 2023

FWIW: laminas totally dropped CHANGELOG file as it was always a pain with merge-ups. Only the milestones receive the CHANGELOG which is then passed to the release-notes via https://github.com/laminas/automatic-releases

@dbu
Copy link
Contributor

dbu commented Apr 7, 2023

i guess it depends on the activity of a repository. the repositories in php-http are not very active so its easier to manually maintain. the alternative would require to set up some tooling as having no release information at all is problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants