Skip to content

Allow psr/http-message v2 #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

boesing
Copy link
Contributor

@boesing boesing commented Apr 4, 2023

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets fixes #64
Documentation So far, nothing changes
License MIT

What's in this PR?

Provides support for psr/http-message v2

Why?

Executing tests with psr/http-message v2 won't work due to dependency conflicts.

Example Usage

/

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix

To Do

  • Update CHANGELOG.md

@boesing
Copy link
Contributor Author

boesing commented Apr 4, 2023

When executing tests, plenty of checks will fail in the various implementations.
Not sure if this component should have an eye on the various implementations while having failing tests.
Might be a good info to know that something is not supported in those components but I'd not prevent PRs from getting merged due to failing tests tho.

Especially due to the fact that psr/http-message v2 is not installable as of now since none of the dev required components do support these yet (as they need this component to support v2 first).

@dbu
Copy link
Contributor

dbu commented Apr 4, 2023

thanks a lot. in #62 i fixed the ci to run the tests of all suites.

i am not quite sure how we should handle it, because there will be failures caused by the implementations that we do not fix, only highlight. maybe we could mark those ci builds as allowed to fail to make that more obvious.

@boesing
Copy link
Contributor Author

boesing commented Apr 4, 2023

maybe we could mark those ci builds as allowed to fail to make that more obvious.

Yah, could also be a comment to the PR where the runner says which tests are actually failing. Afaik, GHA has no such "allow_failures" as in travis. I've experimented a lot with it in the laminas CI pipeline and at least at that time was not able to have that properly marked in GITHUB UI as these checks are not properly marked yellow but AFAIR green.
So having an additional comment would be super helpful but not sure if there is already something like this available.

@boesing boesing changed the title feature: allow psr/http-message v2 Allow psr/http-message v2 Apr 4, 2023
boesing added 2 commits April 4, 2023 16:06
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@dbu
Copy link
Contributor

dbu commented Apr 5, 2023

@boesing ok to close in favor of #68 ?

@boesing
Copy link
Contributor Author

boesing commented Apr 5, 2023

@dbu absolutely

@boesing boesing closed this Apr 5, 2023
@boesing boesing deleted the feature/psr-http-message-v2 branch April 5, 2023 07:51
@dbu
Copy link
Contributor

dbu commented Apr 5, 2023

maybe we could mark those ci builds as allowed to fail to make that more obvious.

Yah, could also be a comment to the PR where the runner says which tests are actually failing. Afaik, GHA has no such "allow_failures" as in travis. I've experimented a lot with it in the laminas CI pipeline and at least at that time was not able to have that properly marked in GITHUB UI as these checks are not properly marked yellow but AFAIR green. So having an additional comment would be super helpful but not sure if there is already something like this available.

ah indeed, was thinking of travis-ci it seems. actions/runner#2347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for recently released psr/http-message v2
2 participants