-
Notifications
You must be signed in to change notification settings - Fork 22
Allow psr/http-message
v2
#65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When executing tests, plenty of checks will fail in the various implementations. Especially due to the fact that |
thanks a lot. in #62 i fixed the ci to run the tests of all suites. i am not quite sure how we should handle it, because there will be failures caused by the implementations that we do not fix, only highlight. maybe we could mark those ci builds as allowed to fail to make that more obvious. |
Yah, could also be a comment to the PR where the runner says which tests are actually failing. Afaik, GHA has no such "allow_failures" as in travis. I've experimented a lot with it in the laminas CI pipeline and at least at that time was not able to have that properly marked in GITHUB UI as these checks are not properly marked yellow but AFAIR green. |
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
f8fff78
to
52fea19
Compare
@dbu absolutely |
ah indeed, was thinking of travis-ci it seems. actions/runner#2347 |
What's in this PR?
Provides support for
psr/http-message
v2Why?
Executing tests with
psr/http-message
v2 won't work due to dependency conflicts.Example Usage
/
Checklist
To Do