Introduce userInfo encoding tests
#67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boesing
force-pushed
the
feature/test-psr7-uri-userinfo-encoding
branch
from
188be3d to
db2e1e0
Compare
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
boesing
force-pushed
the
feature/test-psr7-uri-userinfo-encoding
branch
from
db2e1e0 to
3f8f2dd
Compare
dbu
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
thanks a lot!
we should add another test for the weird case where there are characters that look encoded and others that are not, e.g. pa%65sw:ord
we discuss this in php-fig/fig-standards#1298 but its unclear there what the expected behaviour is. i will merge this as is for now and create a new issue about the mixed case.
akrabat
added a commit
to akrabat/Slim-Psr7
that referenced
this pull request
Apr 10, 2023
Uri:withUserInfo() must not encode already encoded and reserved characters. See php-http/psr7-integration-tests#67.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
There are two new tests added which verify that the
UriInterface#withUserInfocan handle both already encoded and reserved characters.Why?
Due to the interoperability idea, all PSR-7 implementations should behave the same. I recently found out that not all PSR-7 implementations do behave the same and thus I ended up having invalid URIs.
Checklist
To Do