Skip to content

move from defunct travis to github workflow #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2023
Merged

move from defunct travis to github workflow #62

merged 1 commit into from
Apr 7, 2023

Conversation

dbu
Copy link
Contributor

@dbu dbu commented Apr 2, 2023

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets fix #50
Documentation README.md is being updated
License MIT

What's in this PR?

Use github workflow to run the test suite with the known implementaitons

Why?

travis-ci no longer works

To Do

  • Adjust readme to link to github action runs

@dbu dbu force-pushed the fix-setup branch 10 times, most recently from 2b23d5a to 9a0b21b Compare April 2, 2023 08:35
@dbu dbu changed the title WIP: move from defunct travis to github workflow move from defunct travis to github workflow Apr 2, 2023
@dbu
Copy link
Contributor Author

dbu commented Apr 2, 2023

this runs the tests again and shows the problems.

  • laminas is the only implementation that has green builds (but only with PHP 8, some things have not been fixed in legacy versions that still support PHP 7). i wonder if we should only build with 8, or should allow failures with php 7
  • guzzle and slim have only a few failures
  • nyholm should be green when 1.6 is released (it is using these integration tests in its own test suite)
  • ring central looks much less close to the expectations

@GrahamCampbell are you currently maintaining guzzle? there seem to be some missing validations, do you think we can fix them in guzzle?

@dbu dbu merged commit de17925 into master Apr 7, 2023
@dbu dbu deleted the fix-setup branch April 7, 2023 09:00
@GrahamCampbell
Copy link

Thanks for the ping. We're are of this issue, and will look into it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants