Nyholm missing integration tests #50
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 28, 2021 14:13
|
In case this package does execute integration tests for known PSR-7 implementation, this should be merged. |
1 task
|
looks like this used to build with travis-ci but thats now defunct. i have now started fixing the ci setup in #62. nyholm uses these integration tests to test itself, and provides the adapter in its own repository. but becaues of its |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
The PR include integration tests for nyholm/psr7 implementation.
Why?
The following command fails under PHPUnit 9.5.4, PHP 8.0.3 :
php-http/psr7-integration-tests came out-of-the-box with some implementations, I think it should also include Nyholm integration with it, since "vendor/nyholm/psr7/tests" doesn't exists.