Do not pass client_name option to PluginClient constructor #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #71, I missed to remove the
client_name
option from the options array before using it asPluginClient
constructor third argument.Before choosing to use
unset
, I was thinking to add theclient_name
option toPluginClient
, use theOptionsResolver
to set a default client name and add a getter to retrieve the client name. I don't choosed this way to not change anything inPluginClient
, but if you find this solution better than theunset
one, I would be happy to update this PR.