Merge pull request #84 from fbourigault/fix-plugin-client-factory

Do not pass client_name option to PluginClient constructor

Author: Nyholm

spec/PluginClientFactorySpec.php

@@ -18,4 +18,9 @@ function it_returns_a_plugin_client(HttpClient $httpClient)
 
         $client->shouldHaveType('Http\Client\Common\PluginClient');
     }
+
+    function it_does_not_construct_plugin_client_with_client_name_option(HttpClient $httpClient)
+    {
+        $this->createClient($httpClient, [], ['client_name' => 'Default']);
+    }
 }

src/PluginClientFactory.php

@@ -55,6 +55,8 @@ public function createClient($client, array $plugins = [], array $options = [])
             return $factory($client, $plugins, $options);
         }
 
+        unset($options['client_name']);
+
         return new PluginClient($client, $plugins, $options);
     }
 }