Skip to content

Do not pass client_name option to PluginClient constructor #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2017
Merged

Do not pass client_name option to PluginClient constructor #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions spec/PluginClientFactorySpec.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,9 @@ function it_returns_a_plugin_client(HttpClient $httpClient)

$client->shouldHaveType('Http\Client\Common\PluginClient');
}

function it_does_not_construct_plugin_client_with_client_name_option(HttpClient $httpClient)
{
$this->createClient($httpClient, [], ['client_name' => 'Default']);
}
}
2 changes: 2 additions & 0 deletions src/PluginClientFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@ public function createClient($client, array $plugins = [], array $options = [])
return $factory($client, $plugins, $options);
}

unset($options['client_name']);

return new PluginClient($client, $plugins, $options);
}
}