REF/TST: method-specific files for Series timeseries methods #32226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
added
Refactor
|
@jbrockmendel running this PR |
|
test_localized_at_time_between_time gets split into test_localized_at_time and test_localize_between_time. Since that is parametrized over two values, that accounts for 2 extra tests. not clear where the third is coming from. ill see if i can narrow it down |
jbrockmendel
force-pushed
the
tst-methods-8
branch
from
13dfd3a to
a53b89a
Compare
|
The third extra test was a test_between in test_period.py that was left behind, just updated. |
simonjayhawkins
approved these changes
Feb 25, 2020
|
Thanks @jbrockmendel |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @WillAyd @simonjayhawkins got the go ahead the other day to take these off Jeff's plate