Skip to content

REF/TST: method-specific files for DataFrame timeseries methods #32230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 25, 2020

Conversation

jbrockmendel
Copy link
Member

xref #32226.

@jbrockmendel jbrockmendel added Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite labels Feb 25, 2020
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

import numpy as np
import pytest

from pandas import DataFrame, NaT, date_range
import pandas._testing as tm


@pytest.fixture(params=product([True, False], [True, False]))
def close_open_fixture(request):
return request.param
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this does not have utility beyond the one test in pandas/tests/frame/methods/test_between_time.py, I would remove in a follow-up

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed

@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Feb 25, 2020
@simonjayhawkins simonjayhawkins merged commit 69f4c70 into pandas-dev:master Feb 25, 2020
@simonjayhawkins
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the tst-methods-9 branch February 25, 2020 20:49
roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants