Chore/remove remaining globals #1281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-courtis
changed the base branch from
master
to
chore/move-renderer-globals-2
alex-courtis
commented
May 22, 2022
| @@ -83,7 +83,7 @@ local function get_icons_(node) | |||
|
|
|||
| local icons = M.git_icons[git_status] | |||
| if not icons then | |||
| if vim.g.nvim_tree_git_hl ~= 1 then | |||
| if not M.config.highlight_git then | |||
There was a problem hiding this comment.
I do not understands what this does, however it should still work.
alex-courtis
commented
May 22, 2022
| Note that options under the `g:` command should be set **BEFORE** running the setup function. | ||
| These are being migrated to the setup function incrementally, check [this issue](https://github.com/kyazdani42/nvim-tree.lua/issues/674) if you encounter any problems related to configs not working after update. | ||
| Legacy `g:` options have been migrated to the setup function. See [this issue](https://github.com/kyazdani42/nvim-tree.lua/issues/674) for information on migrating your configuration. | ||
|
|
There was a problem hiding this comment.
We can probably tidy the setup bits of the readme, maybe replacing the .vim configuration with .lua.
That can be done afterwards.
Merged
|
thanks of a lot for working on this :) |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #1279 #1280 first.
All
g:gone.