Chore/move renderer globals - Round 2 #1280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-courtis
commented
May 22, 2022
| @@ -1,61 +0,0 @@ | |||
| local M = {} | |||
alex-courtis
commented
May 22, 2022
| function M.setup(opts) | ||
| M.config = opts.renderer.icons | ||
|
|
||
| M.devicons = pcall(require, "nvim-web-devicons") and require "nvim-web-devicons" |
alex-courtis
commented
May 22, 2022
| @@ -146,21 +143,17 @@ local function get_highlight_(node) | |||
| return git_hl[git_status] | |||
| end | |||
|
|
|||
| M.get_icons = nil_ | |||
| M.get_highlight = nil_ | |||
| function M.setup(opts) | |||
There was a problem hiding this comment.
Reload was unnecessary; these can be set once.
alex-courtis
commented
May 22, 2022
| @@ -84,9 +83,6 @@ local function get_links() | |||
| end | |||
|
|
|||
| function M.setup() | |||
| if icons.get_config().show_file_icon and icons.get_config().has_devicons then | |||
| require("nvim-web-devicons").setup() | |||
There was a problem hiding this comment.
Moved to nvim-tree.setup
Merged
alex-courtis
changed the title
alex-courtis
commented
May 22, 2022
| @@ -131,6 +131,35 @@ Values may be functions. Warning: this may result in unexpected behaviour. | |||
| git_placement = "before", | |||
| padding = " ", | |||
| symlink_arrow = " ➛ ", | |||
| show = { | |||
| file = true, | |||
There was a problem hiding this comment.
Plurals were removed e.g. files -> file, as they were inconsistent.
alex-courtis
commented
May 22, 2022
doc/nvim-tree-lua.txt
Outdated
| folder_arrow = true, | ||
| git = true, | ||
| }, | ||
| symbols = { |
There was a problem hiding this comment.
renderer.icons.symbols was the best name I could think of. Ideas welcome.
There was a problem hiding this comment.
Sorry... changed my mind... glyphs now.
Matches https://www.nerdfonts.com/ wording.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge #1279 first.
Simplifies a lot.
help doc has some bad formatting, mixing tabs and spaces. I'll fix the whole file later.