chore/remove globals #1279
Merged
chore/remove globals #1279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pened_files nvim_tree_root_folder_modifier nvim_tree_special_files
kyazdani42
approved these changes
May 21, 2022
|
Merged all three into this branch for a single commit, as we cannot revert just one of the branches. On your final approval I will merge and update #674 I'd like to tweak the README and help a little more, but that can happen later. |
kyazdani42
approved these changes
May 26, 2022
There was a problem hiding this comment.
LGTM !
Thanks a lot for this PR, we should have less issues coming up about people having issues with the setup !
Although we might have a few issues popping up in the next few days.
I'll leave you to merge this and update #674 (if you can, otherwise tell me i'll do it).
|
#674 updated. I do expect a couple of issues and am watchingi for issues. |
|
No issues on my side, config validator was extremely helpful! Great job Alex! |
Almo7aya
pushed a commit
to Almo7aya/nvim-tree.lua
that referenced
this pull request
Oct 11, 2022
* remove renderer globals: nvim_tree_add_trailing nvim_tree_highlight_opened_files nvim_tree_root_folder_modifier nvim_tree_special_files * remove renderer globals: nvim_tree_icon_padding * remove renderer globals: nvim_tree_symlink_arrow * remove renderer globals: nvim_tree_show_icons, nvim_tree_show_icons * remove renderer globals: nvim_tree_git_hl * remove renderer globals: nvim_tree_group_empty * remove renderer globals: respect_buf_cwd * remove renderer globals: nvim_tree_create_in_closed_folder * remove globals: consistency in legacy checks * remove renderer globals: nvim_tree_special_files * renderer.icons.symbols -> glyphs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First round. No significant refactoring. I'll do some more when I get the energy.
Second round, merge after this: #1280
Final round, merge after #1280 : #1281