This repository was archived by the owner on May 10, 2021. It is now read-only.
Add support for Node 10.17.0.
#84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: feature
ehmicky
commented
Nov 16, 2020
| @@ -19,9 +19,6 @@ const { NEXT_VERSION } = require("./nextVersion"); | |||
| // run next-on-netlify. | |||
|
|
|||
| class NextAppBuilder { | |||
| // Name of the app to build. This determines the build path. | |||
| __appName = null; | |||
There was a problem hiding this comment.
Using instance fields is not supported in Node 10.
__appName is used below in path.join() which expects a specific value to have been configured with forTest(). So this can be safely removed.
There was a problem hiding this comment.
things i wouldve probably never found: this
ehmicky
force-pushed
the
chore/add-node-10
branch
from
a92a0bf to
b5ff05e
Compare
ehmicky
commented
Nov 16, 2020
| @@ -26,6 +26,6 @@ jobs: | |||
| with: | |||
| node-version: ${{ matrix.node-version }} | |||
| - name: Install dependencies | |||
| run: npm ci | |||
| run: npm install | |||
There was a problem hiding this comment.
npm ci is not support in the older npm version which comes with Node 10.17.0.
ehmicky
force-pushed
the
chore/add-node-10
branch
from
b5ff05e to
2ca3265
Compare
lindsaylevine
approved these changes
Nov 16, 2020
| @@ -19,9 +19,6 @@ const { NEXT_VERSION } = require("./nextVersion"); | |||
| // run next-on-netlify. | |||
|
|
|||
| class NextAppBuilder { | |||
| // Name of the app to build. This determines the build path. | |||
| __appName = null; | |||
There was a problem hiding this comment.
things i wouldve probably never found: this
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node
10.17.0could not run tests due to a test helpers using a JavaScript feature added in Node 12 (instance fields).This PR fixes this.
It also runs tests on Node
10.17.0and addsengines.nodeto declare the supported Node.js versions.