Skip to content
This repository was archived by the owner on May 10, 2021. It is now read-only.

Add support for Node 10.17.0. #84

Merged
merged 1 commit into from
Nov 16, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macOS-latest]
node-version: [12.x, 14.x]
node-version: [10.17.0, 14.x]
exclude:
- os: macOS-latest
node-version: 12.x
node-version: 10.17.0
fail-fast: false
steps:
- name: Git checkout
Expand All @@ -26,6 +26,6 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- name: Install dependencies
run: npm ci
run: npm install
Copy link
Contributor Author

@ehmicky ehmicky Nov 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm ci is not support in the older npm version which comes with Node 10.17.0.

- name: Tests
run: npm test
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,5 +59,8 @@
"hooks": {
"pre-commit": "prettier --check ."
}
},
"engines": {
"node": ">=10.17.0"
}
}
3 changes: 0 additions & 3 deletions tests/helpers/buildNextApp.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ const { NEXT_VERSION } = require("./nextVersion");
// run next-on-netlify.

class NextAppBuilder {
// Name of the app to build. This determines the build path.
__appName = null;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using instance fields is not supported in Node 10.

__appName is used below in path.join() which expects a specific value to have been configured with forTest(). So this can be safely removed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

things i wouldve probably never found: this


// Set the application name. This determines the build path.
forTest(testFile) {
this.__appName = parse(testFile).name;
Expand Down