Skip to content
This repository was archived by the owner on May 10, 2021. It is now read-only.

use configurable functionsDir and publishDir throughout NoN #89

Merged
merged 2 commits into from
Nov 17, 2020
Merged

use configurable functionsDir and publishDir throughout NoN #89

merged 2 commits into from
Nov 17, 2020

Conversation

lindsaylevine
Copy link
Contributor

@lindsaylevine lindsaylevine added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Nov 17, 2020
lindsaylevine
lindsaylevine commented Nov 17, 2020
View reviewed changes
lib/helpers/getNextConfig.js
return loadConfig(PHASE_PRODUCTION_BUILD, resolve("."));
};

module.exports = getNextConfig;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought i'd want and need this file in another part but ended up not using it here (except calling from getNextDistDir). this is a function i'm also adding in the i18n work so we can leave it :)

ehmicky
ehmicky reviewed Nov 17, 2020
View reviewed changes
ehmicky
ehmicky approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@ehmicky ehmicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (except for a small typo), that's amazing!
We might want to update the README.md and udpate the two issues asking for this feature too :)

@lindsaylevine
Copy link
Contributor Author

ok yes ill push up a README commit. when updating the issues that have asked for this feature, are you suggesting we point them to the plugin? otherwise their issue isn't really resolved directly through NoN right?

@ehmicky
Copy link
Contributor

ehmicky commented Nov 17, 2020

Maybe we should update the CLI entrypoint to include those two new options as CLI flags? Like this, we could document it in the README.md (since that only covers the CLI entrypoint, not programmatic). What do you think?

@lindsaylevine
Copy link
Contributor Author

wont that possibly conflict with UI settings? when i was starting this work i started going down that path but stopped knowing id run into toml vs ui issues. i feel like its easier/safer to just defer to the plugin :/

Screen Shot 2020-11-17 at 1 13 42 PM

@ehmicky
Copy link
Contributor

ehmicky commented Nov 17, 2020

Yes, this makes sense! 👍

@lindsaylevine lindsaylevine merged commit d779945 into netlify:main Nov 17, 2020
@lindsaylevine lindsaylevine deleted the ll/configurable-dirs branch November 17, 2020 19:03
lindsaylevine added a commit that referenced this pull request Nov 17, 2020
@lindsaylevine
Publish v2.6.2
ab57c86 
- Upgrade version range of `next` ([#90](#90))
- Configurable functionsDir and publishDir (via exported func only) ([#89](#89))
- Support for Node 10.17.0 ([#84](#84))
- CI tests ([#83](#83))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ehmicky ehmicky ehmicky approved these changes

Assignees
No one assigned
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lindsaylevine @ehmicky