Skip to content

Adding GlobalExclusiveDeviceAccess #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

frobijn
Copy link
Contributor

@frobijn frobijn commented Oct 10, 2024

Description

  • GlobalExclusiveDeviceAccess added for the execution of tests on real hardware. The test framework waits at most 5 seconds to get exclusive access, if that is not granted it will stop trying.

  • .editorconfig added

Motivation and Context

The test framework should get exclusive access as soon as possible, and keep that until the tests are finished. The framework also should have a timeout and not wait indefinite for a device to become available.

How Has This Been Tested?

Using the poc (by reference) and simultaneous access by nanoff.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

Summary by CodeRabbit

  • Chores
    • Updated the version of the nanoFramework.Tools.Debugger.Net dependency to improve stability and performance.

Copy link

coderabbitai bot commented Oct 10, 2024

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (3)
  • .editorconfig is excluded by none and included by none
  • source/TestAdapter/Executor.cs is excluded by none and included by none
  • spelling_exclusion.dic is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes in this pull request involve updating the versioning details of the nanoFramework.Tools.Debugger.Net dependency within the packages.lock.json file. The requested version has been changed from [2.4.42, ) to [2.4.46, ), and the resolved version has been updated from 2.4.42 to 2.4.46. Additionally, the content hash for this dependency has been modified to align with the new version. No other dependencies were affected by this update.

Changes

File Change Summary
source/TestAdapter/packages.lock.json Updated nanoFramework.Tools.Debugger.Net dependency version from 2.4.42 to 2.4.46 and modified content hash.

Possibly related PRs

  • Update 1 NuGet dependencies #267: The changes in this PR involve updating the versioning information in a packages.lock.json file, similar to the main PR's update of the nanoFramework.Tools.Debugger.Net dependency in its own packages.lock.json.

Suggested labels

Type: dependencies


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 619c107 and 3256c3e.

⛔ Files ignored due to path filters (4)
  • .editorconfig is excluded by none and included by none
  • source/TestAdapter/Executor.cs is excluded by none and included by none
  • source/TestAdapter/nanoFramework.TestAdapter.csproj is excluded by none and included by none
  • spelling_exclusion.dic is excluded by none and included by none
📒 Files selected for processing (1)
  • source/TestAdapter/packages.lock.json (1 hunks)
🧰 Additional context used

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes changed the title GlobalExclusiveDeviceAccess added to (current) testframework Adding GlobalExclusiveDeviceAccess Nov 7, 2024
@josesimoes josesimoes requested a review from Ellerbach November 7, 2024 17:54
Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, couple of minor comments.

@josesimoes josesimoes force-pushed the GlobalExclusiveDeviceAccess branch from 98deb4e to d1ca1ce Compare November 18, 2024 11:20
@josesimoes josesimoes enabled auto-merge (squash) November 18, 2024 11:20
@josesimoes josesimoes merged commit c785652 into nanoframework:main Nov 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants