-
-
Notifications
You must be signed in to change notification settings - Fork 9
Adding GlobalExclusiveDeviceAccess
#271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding GlobalExclusiveDeviceAccess
#271
Conversation
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (3)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the WalkthroughThe changes in this pull request involve updating the versioning details of the Changes
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (4)
.editorconfig
is excluded by none and included by nonesource/TestAdapter/Executor.cs
is excluded by none and included by nonesource/TestAdapter/nanoFramework.TestAdapter.csproj
is excluded by none and included by nonespelling_exclusion.dic
is excluded by none and included by none
📒 Files selected for processing (1)
- source/TestAdapter/packages.lock.json (1 hunks)
🧰 Additional context used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
GlobalExclusiveDeviceAccess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, couple of minor comments.
Co-authored-by: Laurent Ellerbach <laurelle@microsoft.com>
98deb4e
to
d1ca1ce
Compare
Description
GlobalExclusiveDeviceAccess added for the execution of tests on real hardware. The test framework waits at most 5 seconds to get exclusive access, if that is not granted it will stop trying.
.editorconfig added
Motivation and Context
The test framework should get exclusive access as soon as possible, and keep that until the tests are finished. The framework also should have a timeout and not wait indefinite for a device to become available.
How Has This Been Tested?
Using the poc (by reference) and simultaneous access by nanoff.
Types of changes
Checklist:
Summary by CodeRabbit
nanoFramework.Tools.Debugger.Net
dependency to improve stability and performance.