DOCSP-41986: multikey indexes #140
Conversation
✅ Deploy Preview for docs-php-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
source/indexes/multikey-index.txt
Outdated
| **Multikey indexes** are indexes that improve the performance of queries | ||
| on array-valued fields. You can create a multikey index on a collection | ||
| by using the ``MongoDB\Collection::createIndex()`` method and the same | ||
| syntax that you use to create single field or compound indexes. |
There was a problem hiding this comment.
S: Might be helpful to link to the single field and compound index pages as you mention them here
rustagir
requested review from
a team and
GromNaN
and removed request for
a team
source/includes/indexes/indexes.php
Outdated
| $document = $collection->findOne( | ||
| ['cast' => ['$in' => ['Aamir Khan', 'Kajol']]] | ||
| ); | ||
| echo json_encode($document) , PHP_EOL; |
There was a problem hiding this comment.
In the index landing PR (#127), I suggested using some driver functions to print the value as extended JSON. It looks like that was missed in a subsequent PR for single field indexes (#134), upon which I expect this was based.
I'll defer to you if it's worth changing. The expected output in the RST doesn't show any special BSON types, so it's probably of little consequence.
| echo json_encode($document) , PHP_EOL; | |
| echo json_encode($document), PHP_EOL; |
No need for preceding whitespace for a comma. It would be appropriate for a concatenation operator (dot), though.
There was a problem hiding this comment.
I think it's ok to use the simpler json_encode() method in these contexts. I will change the whitespace though!
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-41986
Staging - https://preview-mongodbrustagir.gatsbyjs.io/php-library/DOCSP-41986-multikey-indexes/indexes/multikey-index/
Self-Review Checklist