Skip to content

DOCSP-41984: single field index #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rustagir
Copy link
Collaborator

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-41984
Staging:

Self-Review Checklist

  • Is this free of any warnings or errors in the RST? all errors unrelated
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for docs-php-library ready!

Name Link
🔨 Latest commit afd284a
🔍 Latest deploy log https://app.netlify.com/sites/docs-php-library/deploys/66e1f957acb2d400087cf8d5
😎 Deploy Preview https://deploy-preview-134--docs-php-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM w/ a few suggestions

Comment on lines 49 to 50
indexes, see the :manual:`Data Modeling and Indexes
</core/data-model-operations/#indexes>` guide in the {+mdb-server+}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing title has changed in the linked section, it's just "Indexes" now

Suggested change
indexes, see the :manual:`Data Modeling and Indexes
</core/data-model-operations/#indexes>` guide in the {+mdb-server+}
indexes, see the :manual:`Indexes
</core/data-model-operations/#indexes>` guide in the {+mdb-server+}

Delete All Indexes
~~~~~~~~~~~~~~~~~~

You can drop all indexes by calling the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can drop all indexes by calling the
You can delete all indexes by calling the

Comment on lines 24 to 27
document in a collection. These indexes improve single field query and
sort performance, and support :manual:`TTL Indexes </core/index-ttl>`
that automatically remove documents from a collection after a certain
amount of time or at a specified clock time.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: I think this might work better broken into two sentences since it's a pretty long sentence as-is

Suggested change
document in a collection. These indexes improve single field query and
sort performance, and support :manual:`TTL Indexes </core/index-ttl>`
that automatically remove documents from a collection after a certain
amount of time or at a specified clock time.
document in a collection. These indexes improve single field query and
sort performance. They also support :manual:`TTL Indexes </core/index-ttl>`
that automatically remove documents from a collection after a certain
amount of time or at a specified clock time.

@rustagir rustagir requested review from a team and alcaeus and removed request for a team September 11, 2024 20:09
@rustagir rustagir merged commit 1f70e6d into mongodb:php-standardization Sep 12, 2024
5 of 6 checks passed
@jmikola jmikola mentioned this pull request Sep 13, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants