Skip to content

DOCSP-41983: indexes landing pg #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rustagir
Copy link
Collaborator

@rustagir rustagir commented Sep 5, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-41983
Staging - https://preview-mongodbrustagir.gatsbyjs.io/php-library/DOCSP-41983-indexes-landing/indexes/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST? not related to pr
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

@rustagir rustagir force-pushed the DOCSP-41983-indexes-landing branch from 335066f to a2c7296 Compare September 5, 2024 19:52
Copy link
Collaborator

@mcmorisi mcmorisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion!

@rustagir rustagir requested review from a team and jmikola and removed request for a team September 6, 2024 14:54
@rustagir rustagir force-pushed the DOCSP-41983-indexes-landing branch from e66dbc3 to b18b221 Compare September 10, 2024 15:03
@rustagir rustagir requested a review from jmikola September 10, 2024 15:17
// start-search-update
$result = $collection->updateSearchIndex(
['name' => '<index name>'],
['mappings' => ['dynamic' => true]],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be able to pull some inspiration from examples I wrote up in the Doctrine ODM project: doctrine/mongodb-odm@fed919f

In particular, there is some code in AbstractMappingDriverTestCase.php that presents both dynamic and non-dynamic search index definitions. Those are expected values from parsing annotations and XML mappings, which are probably less helpful.

I think some of that content is also available via: https://www.doctrine-project.org/projects/doctrine-mongodb-odm/en/latest/reference/search-indexes.html

Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for docs-php-library failed. Why did it fail? →

Name Link
🔨 Latest commit cbc3879
🔍 Latest deploy log https://app.netlify.com/sites/docs-php-library/deploys/66e076517b36c700086359ad

@rustagir
Copy link
Collaborator Author

@jmikola I can take those examples under consideration for the longer Atlas Search index focused guide that is planned: https://jira.mongodb.org/browse/DOCSP-41987

@rustagir rustagir requested a review from jmikola September 10, 2024 16:44
@rustagir rustagir merged commit 55a44c1 into mongodb:php-standardization Sep 10, 2024
1 of 2 checks passed
@jmikola jmikola mentioned this pull request Sep 13, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants