This repository was archived by the owner on Mar 4, 2020. It is now read-only.
chore: Run perf tests in CI #847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miroslavstastny
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
mnajdova
as code owners
miroslavstastny
force-pushed
the
chore/run-perf-in-ci
branch
from
09f6b1d to
47ec92c
Compare
Codecov Report
@@ Coverage Diff @@
## master #847 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 21 21
Lines 728 728
Branches 73 69 -4
=======================================
Hits 681 681
Misses 47 47Continue to review full report at Codecov.
|
Generated by 🚫 dangerJS |
layershifter
reviewed
Feb 6, 2019
| @@ -6,7 +6,7 @@ general: | |||
| jobs: | |||
| build: | |||
| docker: | |||
| - image: circleci/node:8 | |||
| - image: circleci/node:8-browsers | |||
There was a problem hiding this comment.
Not sure about this, puppeteer package will install an own browser. Do we need to switch images?
There was a problem hiding this comment.
Yes.
Puppeteer installs its own Chrome, but it still depends on some shared libraries which are not installed in the original image:
[02:10:55] 'perf:run' errored after 174 ms
[02:10:55] Error: Failed to launch chrome!
/home/circleci/project/node_modules/puppeteer/.local-chromium/linux-609904/chrome-linux/chrome: error while loading shared libraries: libXtst.so.6: cannot open shared object file: No such file or directory
layershifter
approved these changes
Feb 6, 2019
bmdalex
approved these changes
Feb 6, 2019
kuzhelov
approved these changes
Feb 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
yarn perfas part of Ci build, part of #773.No changelog entry, no user-facing change.