This repository was archived by the owner on Mar 4, 2020. It is now read-only.
chore: Save package statistics to DB #821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miroslavstastny
requested review from
dvdzkwsk,
kuzhelov,
layershifter,
levithomason and
mnajdova
as code owners
Generated by 🚫 dangerJS |
miroslavstastny
changed the title
|
This is repo for the DB API endpoint: https://github.com/miroslavstastny/stardust-stats-azure (to be moved to stardust repo later) |
layershifter
reviewed
Feb 4, 2019
layershifter
reviewed
Feb 4, 2019
layershifter
reviewed
Feb 4, 2019
kuzhelov
reviewed
Feb 4, 2019
kuzhelov
added
needs author feedback
Codecov Report
@@ Coverage Diff @@
## master #821 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 21 21
Lines 728 728
Branches 73 69 -4
=======================================
Hits 681 681
Misses 47 47Continue to review full report at Codecov.
|
miroslavstastny
added
🚀 ready for review
and removed
needs author feedback
kuzhelov
approved these changes
Feb 8, 2019
| if [ -n "${STATS_URI}" ]; then | ||
| yarn stats:save | ||
| else | ||
| echo "STATS_URI not set, skipping" |
There was a problem hiding this comment.
Seems this should throw, no? Do we want silent passes when stats aren't being saved for some reason?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #773.
Each CI build stores results of
yarn build:statsto an external DB.Following data are stored:
No magic is currently done on DB side, data is stored as-is. Based on the required queries, we can restructure the data and migrate all existing ones.
No user-facing change, changelog left intentionally blank.