Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Commit 7acf24c

Browse files
chore: Run perf tests in CI (#847)
* Change CircleCI image to contain Chrome * Run `yarn perf` in CI
1 parent a468d8f commit 7acf24c

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

.circleci/config.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ general:
66
jobs:
77
build:
88
docker:
9-
- image: circleci/node:8
9+
- image: circleci/node:8-browsers
1010
environment:
1111
TZ: "/usr/share/zoneinfo/America/Los_Angeles"
1212
steps:
@@ -83,6 +83,9 @@ jobs:
8383
else
8484
echo "STATS_URI not set, skipping"
8585
fi
86+
- run:
87+
name: Performance Tests
88+
command: yarn perf
8689
- run:
8790
name: Danger JS
8891
command: |

build/gulp/tasks/perf.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,9 @@ task('perf:run', async () => {
8686
let browser
8787

8888
try {
89-
browser = await puppeteer.launch()
89+
browser = await puppeteer.launch({
90+
args: ['--single-process'], // Workaround for newPage hang in CircleCI: https://github.com/GoogleChrome/puppeteer/issues/1409#issuecomment-453845568
91+
})
9092

9193
for (let i = 0; i < times; i++) {
9294
const page = await browser.newPage()

0 commit comments

Comments
 (0)