Laravel 9 style fixes #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In Totem.php line 21 using Closure triggers error:
By removing Closure from line 21, it works. |
qschmick
approved these changes
May 9, 2022
qschmick
pushed a commit
that referenced
this pull request
Jun 29, 2022
* Updated to allow Laravel 9 usage; Updated CI to do a matrix of versions * Updated typing * Laravel 9 tests and styling fixed (#327) * allow constraints * fix contract break * reverted types to get tests to pass * remove unneeded element Co-authored-by: James Freeman <me@james-freeman.info> * Laravel 9 style fixes (#330) * Handle null is_active Co-authored-by: Alban Horrocks <alban@townsend-music.com> Co-authored-by: James Freeman <me@james-freeman.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully the last of the style fixes 🤞