-
Notifications
You must be signed in to change notification settings - Fork 229
Laravel 9 #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 9 #314
Conversation
qschmick
commented
Feb 11, 2022
- Updated to allow Laravel 9 usage
- Updated CI to do a matrix of versions
Any idea when this might get merged? |
Any chance we could have minor version bump in the mean time on this one please, it's the only thing holding up our 9 upgrade? 🙏🏻 |
@qschmick Any idea about when will be merged? |
@elfeffe when I get it all passing (tests and styling) |
* allow constraints * fix contract break * reverted types to get tests to pass * remove unneeded element Co-authored-by: James Freeman <me@james-freeman.info>
* more stytle fixes * fix style fix type * another style fix
Any update ? |
+1 |
@@ -56,7 +58,7 @@ class Task extends TotemModel | |||
* | |||
* @return bool | |||
*/ | |||
public function getActivatedAttribute() | |||
public function getActivatedAttribute(): bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have error Studio\Totem\Task::getActivatedAttribute(): Return value must be of type bool, null returned
after trying to add a new task. When created, Task model doesn't have property is_active
set (it's being set by database automatically as column has default value true
). So, as an option, that method body should be return $this->is_active ?? true
. Or we should refresh model in the repository (after that line). Or smth else. Anyway, it's bugged right now.
@iadambrown @albanh @InfluxOW @javis @SwithFr @elfeffe https://github.com/codestudiohq/laravel-totem/releases/tag/v9.0.0 |