Skip to content

Laravel 9 #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 29, 2022
Merged

Laravel 9 #314

merged 12 commits into from
Jun 29, 2022

Conversation

qschmick
Copy link
Collaborator

  • Updated to allow Laravel 9 usage
  • Updated CI to do a matrix of versions

@qschmick qschmick self-assigned this Feb 11, 2022
@qschmick qschmick mentioned this pull request Feb 22, 2022
@iadambrown
Copy link

Any idea when this might get merged?

@albanh
Copy link
Contributor

albanh commented Mar 16, 2022

Any chance we could have minor version bump in the mean time on this one please, it's the only thing holding up our 9 upgrade? 🙏🏻

@elfeffe
Copy link

elfeffe commented Mar 21, 2022

@qschmick Any idea about when will be merged?

@qschmick
Copy link
Collaborator Author

@elfeffe when I get it all passing (tests and styling)

@albanh
Copy link
Contributor

albanh commented May 6, 2022

@qschmick does this now sort tests and styling? #327. Keen to get this sorted as this is the only package we have holding us back for Laravel 9 and would be a real shame to have to drop it as it's really useful. Cheers

albanh and others added 2 commits May 6, 2022 08:30
* allow constraints

* fix contract break

* reverted types to get tests to pass

* remove unneeded element

Co-authored-by: James Freeman <me@james-freeman.info>
* more stytle fixes

* fix style fix type

* another style fix
@SwithFr
Copy link

SwithFr commented May 11, 2022

Any update ?

@javis
Copy link

javis commented May 11, 2022

+1

@@ -56,7 +58,7 @@ class Task extends TotemModel
*
* @return bool
*/
public function getActivatedAttribute()
public function getActivatedAttribute(): bool
Copy link

@InfluxOW InfluxOW Jun 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have error Studio\Totem\Task::getActivatedAttribute(): Return value must be of type bool, null returned after trying to add a new task. When created, Task model doesn't have property is_active set (it's being set by database automatically as column has default value true). So, as an option, that method body should be return $this->is_active ?? true. Or we should refresh model in the repository (after that line). Or smth else. Anyway, it's bugged right now.

Here's the full log.

@qschmick qschmick changed the base branch from 8.0 to 9.0 June 29, 2022 13:24
@qschmick qschmick merged commit 4f65a2c into 9.0 Jun 29, 2022
@qschmick qschmick deleted the feature/laravel-9 branch June 29, 2022 14:46
@qschmick
Copy link
Collaborator Author

@iadambrown @albanh @InfluxOW @javis @SwithFr @elfeffe
New 9.x release, sorry for the long delay, work and home life has been crazy. Thanks all those that helped and reviewed changes.

https://github.com/codestudiohq/laravel-totem/releases/tag/v9.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants