Skip to content

Laravel 9 style fixes #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Http/Controllers/ExportTasksController.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ class ExportTasksController extends Controller

/**
* ExportTasksController constructor.
*
* @param TaskInterface $tasks
*/
public function __construct(TaskInterface $tasks)
Expand Down
1 change: 1 addition & 0 deletions src/Http/Controllers/ImportTasksController.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ class ImportTasksController extends Controller

/**
* ImportTasksController constructor.
*
* @param TaskInterface $tasks
*/
public function __construct(TaskInterface $tasks)
Expand Down
2 changes: 1 addition & 1 deletion src/Http/Controllers/TasksController.php
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public function create(): View
/**
* Store a newly created task in storage.
*
* @param TaskRequest $request
* @param TaskRequest $request
* @return RedirectResponse
*/
public function store(TaskRequest $request): RedirectResponse
Expand Down
7 changes: 3 additions & 4 deletions src/Traits/FrontendSortable.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,9 @@
trait FrontendSortable
{
/**
* @param Builder $builder
* @param array $sortableColumns
* @param array $defaultSort
*
* @param Builder $builder
* @param array $sortableColumns
* @param array $defaultSort
* @return Builder
*/
public function scopeSortableBy(Builder $builder, array $sortableColumns, array $defaultSort = ['name' => 'asc']): Builder
Expand Down
4 changes: 2 additions & 2 deletions src/Traits/HasFrequencies.php
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ public function getCronExpression(): string
/**
* Determine if the filters pass for the event.
*
* @param Application $app
* @param Application $app
* @return bool
*/
public function filtersPass(Application $app): bool
Expand All @@ -145,7 +145,7 @@ public function filtersPass(Application $app): bool
/**
* Register a callback to further filter the schedule.
*
* @param Closure $callback
* @param Closure $callback
* @return $this
*/
public function when(Closure $callback): static
Expand Down
4 changes: 2 additions & 2 deletions tests/Feature/ViewDashboardTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ public function view_dashboard_multiple_tasks_with_multiple_results()
}

/**
* @param int $task_count
* @param int $result_count
* @param int $task_count
* @param int $result_count
* @return mixed
*/
private function _get_task_with_results($task_count = 1, $result_count = 1)
Expand Down