Skip to content

Ignore static dojos from stats #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 8, 2018
Merged

Conversation

yasulab
Copy link
Member

@yasulab yasulab commented Jan 8, 2018

うーん、Static に追加した道場が EventHistories に追加されていないから、「開催回数の合計」が「これまでの開催回数」と一致しない問題が... 😓 Static に追加した道場は統計ページから外した方が、より信頼できる数字になりそうかな 🤔
#229 (comment)

cf. #206

  • 静的な道場数を統計から外す 163f3a0
  • 計測対象の道場数を年次で表示する
  • 表の文言を調整する

@yasulab yasulab changed the title Ignore static dojos from stats [WIP] Ignore static dojos from stats Jan 8, 2018
@yasulab yasulab mentioned this pull request Jan 8, 2018
5 tasks
@yasulab yasulab changed the title [WIP] Ignore static dojos from stats Ignore static dojos from stats Jan 8, 2018
Dojo.where(created_at:
Time.zone.local(2012).beginning_of_year..Time.zone.local(year).end_of_year).count
Dojo.where(created_at: Time.zone.local(2012).beginning_of_year..Time.zone.local(year)
.end_of_year).select{|d| d.dojo_event_services.any?}.count
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここはもっといいやり方ありそう🤔

@yasulab
Copy link
Member Author

yasulab commented Jan 8, 2018

開催回数と参加者数と同様にして、道場数も計測対象のみの数字を表示するようにしました! これでより実態に近い数字になったかなと思います🤔
screen shot 2018-01-08 at 12 04 23

@yasulab yasulab requested a review from nalabjp January 8, 2018 03:06
@yasulab
Copy link
Member Author

yasulab commented Jan 8, 2018

Stats 以外には影響ないはずなので、本番環境で一旦動かしてみます (リファクタリングはあとでやります)

@yasulab yasulab merged commit c0c1a20 into master Jan 8, 2018
@yasulab yasulab deleted the remove-static-dojos-from-stats branch January 8, 2018 03:08
@nalabjp nalabjp mentioned this pull request Jan 8, 2018
@yasulab yasulab added the 統計情報 Tracking event record function via APIs: https://coderdojo.jp/stats label Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
統計情報 Tracking event record function via APIs: https://coderdojo.jp/stats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant