Skip to content

Refactor dojo count #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 9, 2018
Merged

Refactor dojo count #235

merged 2 commits into from
Jan 9, 2018

Conversation

nalabjp
Copy link
Member

@nalabjp nalabjp commented Jan 8, 2018

#234 (comment)

dojo_event_servicesテーブルをINNER JOINしてDISTINCTするとSQLだけで集計できそうです。
道場数が最新ではないんですが、rails consoleで試してみるとこんな感じになるでしょうか。

5.1.4@2.4.2 (main)> Dojo.where(created_at: Time.zone.local(2012).beginning_of_year..Time.zone.local(2017).end_of_year).count
   (0.2ms)  SELECT COUNT(*) FROM "dojos" WHERE ("dojos"."created_at" BETWEEN ? AND ?)  [["created_at", "2011-12-31 15:00:00"], ["created_at", "2017-12-31 14:59:59.999999"]]
=> 113
5.1.4@2.4.2 (main)> Dojo.where(created_at: Time.zone.local(2012).beginning_of_year..Time.zone.local(2017).end_of_year).eager_load(:dojo_event_services).select{|d| d.dojo_event_services.any?}.count

  SQL (1.8ms)  SELECT "dojos"."id" AS t0_r0, "dojos"."name" AS t0_r1, "dojos"."email" AS t0_r2, "dojos"."order" AS t0_r3, "dojos"."description" AS t0_r4, "dojos"."logo" AS t0_r5, "dojos"."url" AS t0_r6, "dojos"."tags" AS t0_r7, "dojos"."created_at" AS t0_r8, "dojos"."updated_at" AS t0_r9, "dojos"."prefecture_id" AS t0_r10, "dojo_event_services"."id" AS t1_r0, "dojo_event_services"."dojo_id" AS t1_r1, "dojo_event_services"."name" AS t1_r2, "dojo_event_services"."url" AS t1_r3, "dojo_event_services"."group_id" AS t1_r4, "dojo_event_services"."created_at" AS t1_r5, "dojo_event_services"."updated_at" AS t1_r6 FROM "dojos" LEFT OUTER JOIN "dojo_event_services" ON "dojo_event_services"."dojo_id" = "dojos"."id" WHERE ("dojos"."created_at" BETWEEN ? AND ?)  [["created_at", "2011-12-31 15:00:00"], ["created_at", "2017-12-31 14:59:59.999999"]]
=> 70
5.1.4@2.4.2 (main)> res1 = Dojo.where(created_at: Time.zone.local(2012).beginning_of_year..Time.zone.local(2017).end_of_year).eager_load(:dojo_event_services).select{|d| d.dojo_event_services.any?}.map(&:id);

  SQL (1.9ms)  SELECT "dojos"."id" AS t0_r0, "dojos"."name" AS t0_r1, "dojos"."email" AS t0_r2, "dojos"."order" AS t0_r3, "dojos"."description" AS t0_r4, "dojos"."logo" AS t0_r5, "dojos"."url" AS t0_r6, "dojos"."tags" AS t0_r7, "dojos"."created_at" AS t0_r8, "dojos"."updated_at" AS t0_r9, "dojos"."prefecture_id" AS t0_r10, "dojo_event_services"."id" AS t1_r0, "dojo_event_services"."dojo_id" AS t1_r1, "dojo_event_services"."name" AS t1_r2, "dojo_event_services"."url" AS t1_r3, "dojo_event_services"."group_id" AS t1_r4, "dojo_event_services"."created_at" AS t1_r5, "dojo_event_services"."updated_at" AS t1_r6 FROM "dojos" LEFT OUTER JOIN "dojo_event_services" ON "dojo_event_services"."dojo_id" = "dojos"."id" WHERE ("dojos"."created_at" BETWEEN ? AND ?)  [["created_at", "2011-12-31 15:00:00"], ["created_at", "2017-12-31 14:59:59.999999"]]
5.1.4@2.4.2 (main)> Dojo.distinct.where(created_at: Time.zone.local(2012).beginning_of_year..Time.zone.local(2017).end_of_year).joins(:dojo_event_services).count
   (0.3ms)  SELECT COUNT(DISTINCT "dojos"."id") FROM "dojos" INNER JOIN "dojo_event_services" ON "dojo_event_services"."dojo_id" = "dojos"."id" WHERE ("dojos"."created_at" BETWEEN ? AND ?)  [["created_at", "2011-12-31 15:00:00"], ["created_at", "2017-12-31 14:59:59.999999"]]
=> 70
5.1.4@2.4.2 (main)> res2 = Dojo.distinct.where(created_at: Time.zone.local(2012).beginning_of_year..Time.zone.local(2017).end_of_year).joins(:dojo_event_services).pluck(:id);
   (0.2ms)  SELECT DISTINCT "dojos"."id" FROM "dojos" INNER JOIN "dojo_event_services" ON "dojo_event_services"."dojo_id" = "dojos"."id" WHERE ("dojos"."created_at" BETWEEN ? AND ?)  [["created_at", "2011-12-31 15:00:00"], ["created_at", "2017-12-31 14:59:59.999999"]]
5.1.4@2.4.2 (main)> res1 == res2
=> true

@yasulab
Copy link
Member

yasulab commented Jan 9, 2018

改善ありがとうございます! なるほど! こんな感じでやるといいんですね😆

@yasulab yasulab merged commit 4607233 into master Jan 9, 2018
@yasulab yasulab deleted the distinct-joins branch January 9, 2018 00:22
@yasulab yasulab added the 統計情報 Tracking event record function via APIs: https://coderdojo.jp/stats label Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
統計情報 Tracking event record function via APIs: https://coderdojo.jp/stats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants