case_sparql_select: Cross-test JSON output and --no-(header,index) flag branches #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is code-motion to give function names to chunks of `case_sparql_select:main`. Some upcoming patch series are going to add features that, when taken together, introduce non-trivial parameter-value cross-dependencies. Moving functionality to functions enables combinatoric testing in a `pytest` space, rather than resorting to copying, pasting, and tweaking many Makefile lines. A future patch series will add the `pytest` script. Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
No effects were observed on Make-managed files. Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
The test pattern for these features encourages an enumerative approach, so a `pytest` script exercising the freshly broken-out functions is now included. No effects were observed on Make-managed files. Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
…lect_cross_json_and_anno_flag_testing
This patch addresses issues with some parameter-values being compatible with some of the DataFrame table rendering functions, but not with certain `orient` parameters of the JSON rendering function. The incompatible pairings are now caught at parameter-parsing time. Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
kchason
approved these changes
Dec 8, 2022
kchason
deleted the
case_sparql_select_cross_json_and_anno_flag_testing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series addresses issues with some parameter-values being compatible with some of the DataFrame table rendering functions, but not with certain
orientparameters of the JSON rendering function. The incompatible pairings are now caught at parameter-parsing time.If this PR is merged, it will also merge #90, #91, and #92.