Skip to content

case_sparql_select: Refactor code #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Conversation

ajnelson-nist
Copy link
Member

This patch is code-motion to give function names to chunks of case_sparql_select:main.

Some upcoming patch series are going to add features that, when taken together, introduce non-trivial parameter-value cross-dependencies.

Moving functionality to functions enables combinatoric testing in a pytest space, rather than resorting to copying, pasting, and tweaking many Makefile lines. A future patch series will add the pytest script.

This patch is code-motion to give function names to chunks of
`case_sparql_select:main`.

Some upcoming patch series are going to add features that, when taken
together, introduce non-trivial parameter-value cross-dependencies.

Moving functionality to functions enables combinatoric testing in a
`pytest` space, rather than resorting to copying, pasting, and tweaking
many Makefile lines.  A future patch series will add the `pytest`
script.

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Copy link
Member Author

ajnelson-nist commented Dec 7, 2022

The upcoming features include flags to turn off column headers and row headers, and JSON output using another pandas.DataFrame method. It turns out in some cases these are not entirely compatible with one another.

@ajnelson-nist ajnelson-nist marked this pull request as ready for review December 8, 2022 13:53
@kchason kchason merged commit 98d4c6b into develop Dec 8, 2022
@ajnelson-nist ajnelson-nist deleted the case_sparql_select_refactor branch April 28, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants