case_sparql_select: Add flags to disable headers and row index numbers #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is code-motion to give function names to chunks of `case_sparql_select:main`. Some upcoming patch series are going to add features that, when taken together, introduce non-trivial parameter-value cross-dependencies. Moving functionality to functions enables combinatoric testing in a `pytest` space, rather than resorting to copying, pasting, and tweaking many Makefile lines. A future patch series will add the `pytest` script. Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
The test pattern for these features encourages an enumerative approach, so a `pytest` script exercising the freshly broken-out functions is now included. No effects were observed on Make-managed files. Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series adds and tests
--no-headerand--no-indexforcase_sparql_select. The flags disable output for some use cases that do not benefit from the annotations. For instance:--no-indexinstead lets each insertion be noted as an added line without other side-effect.--no-headerremoves the header without post-processing.This should be merged after #90 is merged, as it is built on the patch in 90.
There are non-trivial effects on this patch series from #91, so if #91 is merged first, this patch series should catch up with
develop.