Skip to content

build: update to typescript v3.9.5 #19646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 29, 2020
Merged

build: update to typescript v3.9.5 #19646

merged 2 commits into from
Jun 29, 2020

Conversation

devversion
Copy link
Member

  • Updates to TypeScript v3.9.5
  • Updates the size test golden to reflect the latest changes in master. This is unrelated to the TS update, but just happened to came to mind when I looked for other size impact due to the update.

@devversion devversion added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Jun 15, 2020
@devversion devversion requested a review from a team as a code owner June 15, 2020 14:33
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 15, 2020
josephperrott
josephperrott approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added lgtm action: merge The PR is ready for merge by the caretaker labels Jun 15, 2020
crisbeto
crisbeto approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba
Copy link
Contributor

@devversion needs rebase

@devversion devversion force-pushed the build/update-to-typescript-3.9.5 branch from 1c07c97 to 8a81340 Compare June 20, 2020 18:17
@devversion devversion added P2 The issue is important to a large percentage of users, with a workaround and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Jun 23, 2020
@jelbourn jelbourn added the merge: preserve commits When the PR is merged, a rebase and merge should be performed label Jun 26, 2020
@jelbourn
Copy link
Member

@devversion needs rebase

@devversion
build: update to typescript v3.9.5
ea9dc71 
Updates to the latest version of TypeScript. This matches
the TypeScript version used in the latest framework v10.0.0 RC.

angular/angular@6651b41
@devversion devversion force-pushed the build/update-to-typescript-3.9.5 branch from 8a81340 to ffd01e9 Compare June 29, 2020 20:28
@devversion
build: update size test golden to reflect latest changes
eac3022 
The list size test is currently slightly deviating from the golden.
This is due to the TypeScript 3.9.5 update which reverted the IIFE
class wrapping (resulting a size reduction in some cases).

Other cases might be unrelated. i.e. golden has just not been
updated while other component changes have been made.
@devversion devversion force-pushed the build/update-to-typescript-3.9.5 branch from ffd01e9 to eac3022 Compare June 29, 2020 21:09
@devversion
Copy link
Member Author

@jelbourn Rebased

@jelbourn jelbourn added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 29, 2020
@jelbourn jelbourn merged commit f61a6d9 into angular:master Jun 29, 2020
@jelbourn
Copy link
Member

@devversion changed to target: minor due to a merge conflict w/ 10.0.x (since the payload sizes don't exist there)

@devversion devversion mentioned this pull request Jul 1, 2020
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees

@crisbeto crisbeto

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: preserve commits When the PR is merged, a rebase and merge should be performed P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@devversion @mmalerba @jelbourn @crisbeto @josephperrott @googlebot