Skip to content

Commit f61a6d9

Browse files
devversionjelbourn
authored andcommitted
build: update size test golden to reflect latest changes
The list size test is currently slightly deviating from the golden. This is due to the TypeScript 3.9.5 update which reverted the IIFE class wrapping (resulting a size reduction in some cases). Other cases might be unrelated. i.e. golden has just not been updated while other component changes have been made.
1 parent 5563cd2 commit f61a6d9

File tree

4 files changed

+45
-16
lines changed

4 files changed

+45
-16
lines changed

goldens/size-test.yaml

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
cdk/drag-drop/all-directives: 153594
22
cdk/drag-drop/basic: 150852
3-
material-experimental/mdc-chips/basic: 147613
4-
material-experimental/mdc-form-field/advanced: 220865
5-
material-experimental/mdc-form-field/basic: 220028
6-
material/autocomplete/without-optgroup: 208091
7-
material/button-toggle/standalone: 119400
8-
material/chips/basic: 162733
9-
material/datepicker/range-picker/without-form-field: 330747
10-
material/expansion/without-accordion: 130562
11-
material/form-field/advanced: 186234
12-
material/form-field/basic: 185008
13-
material/list/nav-list: 130473
14-
material/menu/without-lazy-content: 210751
15-
material/radio/without-group: 121448
16-
material/select/basic: 256613
17-
material/tabs/advanced: 183627
18-
material/tabs/basic: 182824
3+
material-experimental/mdc-chips/basic: 147608
4+
material-experimental/mdc-form-field/advanced: 220897
5+
material-experimental/mdc-form-field/basic: 220060
6+
material/autocomplete/without-optgroup: 208202
7+
material/button-toggle/standalone: 119486
8+
material/chips/basic: 162755
9+
material/datepicker/range-picker/without-form-field: 330729
10+
material/expansion/without-accordion: 130701
11+
material/form-field/advanced: 186274
12+
material/form-field/basic: 185048
13+
material/list/nav-list: 130612
14+
material/menu/without-lazy-content: 210862
15+
material/radio/without-group: 121587
16+
material/select/basic: 256617
17+
material/tabs/advanced: 183612
18+
material/tabs/basic: 182809

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
"ts-circular-deps:approve": "yarn -s ts-circular-deps approve --config ./src/circular-deps-test.conf.js",
4242
"merge": "ng-dev pr merge",
4343
"approve-api": "node ./scripts/approve-api-golden.js",
44+
"approve-size-tests": "node ./scripts/approve-size-golden.js",
4445
"integration-tests": "bazel test //integration/... --test_tag_filters=-view-engine-only --build_tests_only",
4546
"integration-tests:view-engine": "bazel test //integration/... --test_tag_filters=view-engine-only --build_tests_only --config=view-engine"
4647
},

scripts/approve-api-golden.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
#!/usr/bin/env node
2+
13
const shelljs = require('shelljs');
24
const chalk = require('chalk');
35
const path = require('path');

scripts/approve-size-golden.js

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
#!/usr/bin/env node
2+
3+
const shelljs = require('shelljs');
4+
const path = require('path');
5+
const yaml = require('yaml');
6+
const fs = require('fs');
7+
8+
const projectDir = path.join(__dirname, '../');
9+
const goldenPath = path.join(projectDir, './goldens/size-test.yaml');
10+
const golden = yaml.parse(fs.readFileSync(goldenPath, 'utf8'));
11+
const tests = Object.keys(golden);
12+
13+
if (tests.length === 0) {
14+
console.error('No tests captured in size test golden.');
15+
process.exit(1);
16+
}
17+
18+
shelljs.set('-e');
19+
shelljs.cd(projectDir);
20+
21+
for (const testId of tests) {
22+
const testIdParts = testId.split('/');
23+
const targetLabel = testIdParts.slice(0, -1).join('/');
24+
const targetName = testIdParts[testIdParts.length - 1];
25+
shelljs.exec(`bazel run //integration/size-test/${targetLabel}:${targetName}.approve`);
26+
}

0 commit comments

Comments
 (0)