Skip to content

Commit 6651b41

Browse files
alan-agius4mhevery
authored andcommitted
build: update to typescript 3.9.5 (#37456)
This TypeScript version contains the revert for the classes wrapped in IIFE change that was introduced in version 3.9. PR Close #37456
1 parent 8c682c5 commit 6651b41

File tree

9 files changed

+112
-157
lines changed

9 files changed

+112
-157
lines changed

goldens/size-tracking/aio-payloads.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"master": {
44
"uncompressed": {
55
"runtime-es2015": 2987,
6-
"main-es2015": 454032,
6+
"main-es2015": 453213,
77
"polyfills-es2015": 52685
88
}
99
}
@@ -12,8 +12,8 @@
1212
"master": {
1313
"uncompressed": {
1414
"runtime-es2015": 2987,
15-
"main-es2015": 451918,
16-
"polyfills-es2015": 52655
15+
"main-es2015": 451406,
16+
"polyfills-es2015": 52630
1717
}
1818
}
1919
},

goldens/size-tracking/integration-payloads.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"uncompressed": {
1414
"runtime-es2015": 1485,
1515
"main-es2015": 16959,
16-
"polyfills-es2015": 36657
16+
"polyfills-es2015": 36938
1717
}
1818
}
1919
},
@@ -30,7 +30,7 @@
3030
"master": {
3131
"uncompressed": {
3232
"runtime-es2015": 1485,
33-
"main-es2015": 136873,
33+
"main-es2015": 136302,
3434
"polyfills-es2015": 37640
3535
}
3636
}
@@ -39,8 +39,8 @@
3939
"master": {
4040
"uncompressed": {
4141
"runtime-es2015": 2289,
42-
"main-es2015": 246781,
43-
"polyfills-es2015": 36657,
42+
"main-es2015": 246085,
43+
"polyfills-es2015": 36938,
4444
"5-es2015": 751
4545
}
4646
}
@@ -49,8 +49,8 @@
4949
"master": {
5050
"uncompressed": {
5151
"runtime-es2015": 2289,
52-
"main-es2015": 221961,
53-
"polyfills-es2015": 36657,
52+
"main-es2015": 221268,
53+
"polyfills-es2015": 36938,
5454
"5-es2015": 779
5555
}
5656
}
@@ -62,7 +62,7 @@
6262
"bundle": "TODO(i): we should define ngDevMode to false in Closure, but --define only works in the global scope.",
6363
"bundle": "TODO(i): (FW-2164) TS 3.9 new class shape seems to have broken Closure in big ways. The size went from 169991 to 252338",
6464
"bundle": "TODO(i): after removal of tsickle from ngc-wrapped / ng_package, we had to switch to SIMPLE optimizations which increased the size from 252338 to 1198917, see PR#37221 and PR#37317 for more info",
65-
"bundle": 1198917
65+
"bundle": 1209688
6666
}
6767
}
6868
}

integration/typings_test_ts39/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
"@angular/upgrade": "file:../../dist/packages-dist/upgrade",
2222
"@types/jasmine": "file:../../node_modules/@types/jasmine",
2323
"rxjs": "file:../../node_modules/rxjs",
24-
"typescript": "~3.9.2",
24+
"typescript": "~3.9.5",
2525
"zone.js": "file:../../dist/zone.js-dist/zone.js"
2626
},
2727
"scripts": {

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@
144144
"tsickle": "0.38.1",
145145
"tslib": "^2.0.0",
146146
"tslint": "6.0.0",
147-
"typescript": "~3.9.2",
147+
"typescript": "~3.9.5",
148148
"xhr2": "0.2.0",
149149
"yaml": "^1.7.2",
150150
"yargs": "15.3.0"

packages/bazel/test/ng_package/example_package.golden

Lines changed: 69 additions & 104 deletions
Large diffs are not rendered by default.

packages/bazel/test/ng_package/example_with_ts_library_package.golden

Lines changed: 11 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -287,17 +287,13 @@ export * from './portal-module';
287287
* found in the LICENSE file at https://angular.io/license
288288
*/
289289
import { NgModule } from '@angular/core';
290-
let PortalModule = /** @class */ (() => {
291-
class PortalModule {
292-
}
293-
PortalModule.decorators = [
294-
{ type: NgModule, args: [{},] }
295-
];
296-
return PortalModule;
297-
})();
298-
export { PortalModule };
290+
export class PortalModule {
291+
}
292+
PortalModule.decorators = [
293+
{ type: NgModule, args: [{},] }
294+
];
299295
export const a = 1;
300-
//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoicG9ydGFsLW1vZHVsZS5qcyIsInNvdXJjZVJvb3QiOiIiLCJzb3VyY2VzIjpbIi4uLy4uLy4uLy4uLy4uLy4uLy4uLy4uLy4uL3BhY2thZ2VzL2JhemVsL3Rlc3QvbmdfcGFja2FnZS9leGFtcGxlLXdpdGgtdHMtbGlicmFyeS9wb3J0YWwvcG9ydGFsLW1vZHVsZS50cyJdLCJuYW1lcyI6W10sIm1hcHBpbmdzIjoiQUFBQTs7Ozs7O0dBTUc7QUFFSCxPQUFPLEVBQUMsUUFBUSxFQUFDLE1BQU0sZUFBZSxDQUFDO0FBRXZDO0lBQUEsTUFDYSxZQUFZOzs7Z0JBRHhCLFFBQVEsU0FBQyxFQUFFOztJQUVaLG1CQUFDO0tBQUE7U0FEWSxZQUFZO0FBR3pCLE1BQU0sQ0FBQyxNQUFNLENBQUMsR0FBRyxDQUFDLENBQUMiLCJzb3VyY2VzQ29udGVudCI6WyIvKipcbiAqIEBsaWNlbnNlXG4gKiBDb3B5cmlnaHQgR29vZ2xlIExMQyBBbGwgUmlnaHRzIFJlc2VydmVkLlxuICpcbiAqIFVzZSBvZiB0aGlzIHNvdXJjZSBjb2RlIGlzIGdvdmVybmVkIGJ5IGFuIE1JVC1zdHlsZSBsaWNlbnNlIHRoYXQgY2FuIGJlXG4gKiBmb3VuZCBpbiB0aGUgTElDRU5TRSBmaWxlIGF0IGh0dHBzOi8vYW5ndWxhci5pby9saWNlbnNlXG4gKi9cblxuaW1wb3J0IHtOZ01vZHVsZX0gZnJvbSAnQGFuZ3VsYXIvY29yZSc7XG5cbkBOZ01vZHVsZSh7fSlcbmV4cG9ydCBjbGFzcyBQb3J0YWxNb2R1bGUge1xufVxuXG5leHBvcnQgY29uc3QgYSA9IDE7XG4iXX0=
296+
//# sourceMappingURL=data:application/json;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoicG9ydGFsLW1vZHVsZS5qcyIsInNvdXJjZVJvb3QiOiIiLCJzb3VyY2VzIjpbIi4uLy4uLy4uLy4uLy4uLy4uLy4uLy4uLy4uL3BhY2thZ2VzL2JhemVsL3Rlc3QvbmdfcGFja2FnZS9leGFtcGxlLXdpdGgtdHMtbGlicmFyeS9wb3J0YWwvcG9ydGFsLW1vZHVsZS50cyJdLCJuYW1lcyI6W10sIm1hcHBpbmdzIjoiQUFBQTs7Ozs7O0dBTUc7QUFFSCxPQUFPLEVBQUMsUUFBUSxFQUFDLE1BQU0sZUFBZSxDQUFDO0FBR3ZDLE1BQU0sT0FBTyxZQUFZOzs7WUFEeEIsUUFBUSxTQUFDLEVBQUU7O0FBSVosTUFBTSxDQUFDLE1BQU0sQ0FBQyxHQUFHLENBQUMsQ0FBQyIsInNvdXJjZXNDb250ZW50IjpbIi8qKlxuICogQGxpY2Vuc2VcbiAqIENvcHlyaWdodCBHb29nbGUgTExDIEFsbCBSaWdodHMgUmVzZXJ2ZWQuXG4gKlxuICogVXNlIG9mIHRoaXMgc291cmNlIGNvZGUgaXMgZ292ZXJuZWQgYnkgYW4gTUlULXN0eWxlIGxpY2Vuc2UgdGhhdCBjYW4gYmVcbiAqIGZvdW5kIGluIHRoZSBMSUNFTlNFIGZpbGUgYXQgaHR0cHM6Ly9hbmd1bGFyLmlvL2xpY2Vuc2VcbiAqL1xuXG5pbXBvcnQge05nTW9kdWxlfSBmcm9tICdAYW5ndWxhci9jb3JlJztcblxuQE5nTW9kdWxlKHt9KVxuZXhwb3J0IGNsYXNzIFBvcnRhbE1vZHVsZSB7XG59XG5cbmV4cG9ydCBjb25zdCBhID0gMTtcbiJdfQ==
301297

302298
--- esm2015/portal/portal.externs.js ---
303299

@@ -385,14 +381,11 @@ import { NgModule } from '@angular/core';
385381
* Use of this source code is governed by an MIT-style license that can be
386382
* found in the LICENSE file at https://angular.io/license
387383
*/
388-
let PortalModule = /** @class */ (() => {
389-
class PortalModule {
390-
}
391-
PortalModule.decorators = [
392-
{ type: NgModule, args: [{},] }
393-
];
394-
return PortalModule;
395-
})();
384+
class PortalModule {
385+
}
386+
PortalModule.decorators = [
387+
{ type: NgModule, args: [{},] }
388+
];
396389
const a = 1;
397390

398391
/**

packages/compiler-cli/test/compliance/r3_view_compiler_providers_spec.ts

Lines changed: 15 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -142,24 +142,21 @@ describe('compiler compliance: providers', () => {
142142
const result = compile(files, angularFiles);
143143
expectEmit(
144144
result.source, `
145-
let MyComponent = /** @class */ (() => {
146-
class MyComponent {
147-
}
148-
MyComponent.ɵfac = function MyComponent_Factory(t) { return new (t || MyComponent)(); };
149-
MyComponent.ɵcmp = i0.ɵɵdefineComponent({
150-
type: MyComponent,
151-
selectors: [["my-component"]],
152-
decls: 1,
153-
vars: 0,
154-
template: function MyComponent_Template(rf, ctx) {
155-
if (rf & 1) {
156-
i0.ɵɵelement(0, "div");
157-
}
158-
},
159-
encapsulation: 2
160-
});
161-
return MyComponent;
162-
})();`,
145+
export class MyComponent {
146+
}
147+
MyComponent.ɵfac = function MyComponent_Factory(t) { return new (t || MyComponent)(); };
148+
MyComponent.ɵcmp = i0.ɵɵdefineComponent({
149+
type: MyComponent,
150+
selectors: [["my-component"]],
151+
decls: 1,
152+
vars: 0,
153+
template: function MyComponent_Template(rf, ctx) {
154+
if (rf & 1) {
155+
i0.ɵɵelement(0, "div");
156+
}
157+
},
158+
encapsulation: 2
159+
});`,
163160
'Incorrect features');
164161
});
165162
});

tools/ts-api-guardian/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
"chai": "^4.1.2",
3434
"jasmine": "^3.1.0",
3535
"source-map-support": "^0.5.9",
36-
"typescript": "~3.9.2"
36+
"typescript": "~3.9.5"
3737
},
3838
"repository": {},
3939
"keywords": [

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14252,10 +14252,10 @@ typescript@~3.7.2:
1425214252
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.7.5.tgz#0692e21f65fd4108b9330238aac11dd2e177a1ae"
1425314253
integrity sha512-/P5lkRXkWHNAbcJIiHPfRoKqyd7bsyCma1hZNUGfn20qm64T6ZBlrzprymeu918H+mB/0rIg2gGK/BXkhhYgBw==
1425414254

14255-
typescript@~3.9.2:
14256-
version "3.9.2"
14257-
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.9.2.tgz#64e9c8e9be6ea583c54607677dd4680a1cf35db9"
14258-
integrity sha512-q2ktq4n/uLuNNShyayit+DTobV2ApPEo/6so68JaD5ojvc/6GClBipedB9zNWYxRSAlZXAe405Rlijzl6qDiSw==
14255+
typescript@~3.9.5:
14256+
version "3.9.5"
14257+
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.9.5.tgz#586f0dba300cde8be52dd1ac4f7e1009c1b13f36"
14258+
integrity sha512-hSAifV3k+i6lEoCJ2k6R2Z/rp/H3+8sdmcn5NrS3/3kE7+RyZXm9aqvxWqjEXHAd8b0pShatpcdMTvEdvAJltQ==
1425914259

1426014260
uglify-js@^1.3.3:
1426114261
version "1.3.5"

0 commit comments

Comments
 (0)