fix:(tabs) add call for rechecking tab scroll distance #15173
Conversation
Add call to scroll the tabs header after initialising header pagination, to accurately calculate the scroll distance. Fixes #12889
googlebot
added
the
cla: yes
…2889(tabs)_tabs_hidden_by_arrows
| @@ -604,6 +604,26 @@ describe('MatTabHeader', () => { | |||
| expect(tabHeaderElement.classList).toContain(enabledClass); | |||
| }); | |||
|
|
|||
| it('scroll to last tab', () => { | |||
There was a problem hiding this comment.
nit: we usually start test names with "should".
| {label: 'tab seven'}, | ||
| {label: 'tab eight'}, | ||
| ]; | ||
| appComponent.tabHeader.selectedIndex = 8; |
There was a problem hiding this comment.
Shouldn't this be 7? Index 8 is out of bounds of the array.
|
|
||
| fixture.componentRef.changeDetectorRef.markForCheck(); | ||
|
|
||
| expect(appComponent.tabHeader.scrollDistance) |
There was a problem hiding this comment.
I'm not sure that this test is verifying the correct thing. I tried pasting it into master without the fix from this PR and it still passes. This somewhat defeats the purpose of the test, because we won't know if we accidentally introduce a regression.
andrewseguin
added
the
P3
|
Hi, @andrewseguin sorry but I've forgotten all about this PR. |
|
Closing this in favor of the new PR |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Add call to scroll the tabs header after initialising header pagination, to accurately calculate the scroll distance.
Fixes #12889