Skip to content

fix:(tabs) add call for rechecking tab scroll distance #16200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix:(tabs) add call for rechecking tab scroll distance #16200

wants to merge 1 commit into from

Conversation

lau32
Copy link

@lau32 lau32 commented Jun 4, 2019

Add call to scroll the tabs header after initialising header pagination, to accurately calculate the scroll distance.

Fixes #12889

Add call to scroll the tabs header after initialising header pagination, to accurately calculate the scroll distance.

Fixes #12889
@lau32 lau32 requested a review from andrewseguin as a code owner June 4, 2019 12:54
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 4, 2019
@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jun 10, 2019
@mmalerba mmalerba removed the lgtm label Jul 31, 2020
@andrewseguin andrewseguin added needs rebase and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Dec 29, 2021
@andrewseguin andrewseguin removed their assignment Mar 24, 2022
@andrewseguin
Copy link
Contributor

Sorry for the long delay to give unfortunate news but I dont expect this to land. This is no longer an issue with the MDC tabs and in fact may have been since fixed in the legacy tabs as well. If you find this is still an issue and would like to land it, feel free to open a new rebased version of the PR

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs partially hidden by arrows
4 participants