Skip to content

build: downgrade to sauce-connect v4.5.1 #15183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

@devversion devversion commented Feb 13, 2019

We currently face some flakiness with our Saucelabs job. These randomly exceed the 2min establish timeout because something throws off sauce-connect in a long-lasting loop where it tries to connect to some of their Saucelabs servers.

The initial assumption from the Saucelabs team was that we might have some invalid firewall rules, but this does not answer why this happens randomly, so the latest update from the support is that there have been some changes in the latest version of sauce-connect version that cause this flakiness.

Note that is commit is based on my investigations over at angular/angular. See: angular/angular@6050cd0

e.g. #15173

We currently face a lot of flakiness with our Saucelabs job. These randomly exceed the 2min establish timeout because something throws
off `sauce-connect` in a long-lasting loop where it tries to connect to some of their Saucelabs servers. The initial assumption from the Saucelabs
team was that we might have some invalid firewall rules, but this does not answer why this happens _randomly_, so the latest update from the support
is that there have been some changes in the latest version of `sauce-connect` version that cause this flakiness.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Feb 13, 2019
@devversion devversion requested a review from jelbourn as a code owner February 13, 2019 19:48
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 13, 2019
@devversion devversion changed the title build: downgrade to sauce-connect v4.5.1 (#28659) build: downgrade to sauce-connect v4.5.1 Feb 13, 2019
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Feb 14, 2019
@jelbourn jelbourn merged commit 9ca5722 into angular:master Feb 14, 2019
@devversion devversion deleted the build/downgrade-sauce-connect-v4.5.1 branch February 14, 2019 01:13
jelbourn pushed a commit that referenced this pull request Feb 20, 2019
We currently face a lot of flakiness with our Saucelabs job. These randomly exceed the 2min establish timeout because something throws
off `sauce-connect` in a long-lasting loop where it tries to connect to some of their Saucelabs servers. The initial assumption from the Saucelabs
team was that we might have some invalid firewall rules, but this does not answer why this happens _randomly_, so the latest update from the support
is that there have been some changes in the latest version of `sauce-connect` version that cause this flakiness.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants