refactor: avoid casting document to any in constructor #10775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
amcdnl,
devversion,
jelbourn,
josephperrott,
kara and
mmalerba
as code owners
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
document-constructor-any
branch
from
9b00f73 to
a7fd539
Compare
josephperrott
added
pr: lgtm
action: merge
|
@crisbeto please fix the lint errors |
Removes all the places where we were casting the `Document` to `any` when passing it in to the constructor, in order to avoid AoT compilation issues. It seems like this is no longer necessary as of 6.0.
crisbeto
force-pushed
the
document-constructor-any
branch
from
a7fd539 to
132a468
Compare
|
I'm not seeing any lint errors @tinayuangao. I've rebased it just in case. |
tinayuangao
pushed a commit
that referenced
this pull request
Apr 12, 2018
|
I do not see coerceCssPixelValue in export? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all the places where we were casting the
Documenttoanywhen passing it in to the constructor, in order to avoid AoT compilation issues. It seems like this is no longer necessary as of 6.0.