refactor: avoid casting document to any #10814
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelss95
requested review from
crisbeto,
devversion,
jelbourn and
kara
as code owners
googlebot
added
the
cla: yes
crisbeto
added
pr: lgtm
action: merge
|
Setting as P1 since #10775 was set to P1 as well. |
jelbourn
removed
P1
|
As I mentioned in another PR, not sure we should do this |
|
So, should this PR be closed? |
|
Yeah, we ended up reverting the original change. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically avoid casting document to
anythe leftovers from #10775.In addition to this, it adds some missing
@deletion-target.cc @crisbeto.