Skip to content

Revert "refactor: avoid casting document to any in constructor (#10775)" #10824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2018
Merged

Revert "refactor: avoid casting document to any in constructor (#10775)" #10824

merged 1 commit into from
Apr 12, 2018

Conversation

jelbourn
Copy link
Member

This reverts commit e60f5fc.

@jelbourn jelbourn added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful pr: needs review labels Apr 12, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 12, 2018
crisbeto
crisbeto approved these changes Apr 12, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Apr 12, 2018
@josephperrott josephperrott removed their request for review April 12, 2018 20:07
@tinayuangao tinayuangao merged commit 7f278ad into angular:master Apr 12, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@amcdnl amcdnl Awaiting requested review from amcdnl

@devversion devversion Awaiting requested review from devversion

@kara kara Awaiting requested review from kara

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jelbourn @crisbeto @googlebot @josephperrott @tinayuangao