leafletDraw

[nmccready]

Don't merge this yet. It is mainly to start getting eyes on this.

Still needs:

• more specs
• examples
• documentation

Can make an additional PR as this is 37 files already.

[nmccready]

Start using 2 space indent. I'll fix it as I go; or I can do all the files in another follow up PR.

[simison]

Editors tend to pick what's around, so it might be good idea to do one massive PR instead of leaving mixed styles behind.

[nmccready]

Id rather not do all of it right now as it makes it even harder to review. Ill do it immediately after this PR.

[simison]

Yeah, absolutely, indentation PR has to have only spaces changed and nothing else.

We had this with Meanjs and it was good to watch for a moment with minimum amount of PR's pending.

[nmccready]

@jessertaylor @elesdoar @simison

[elesdoar]

should this PR be on leaflet-1.X branch? We talk about plugins for version 2, no?

[elesdoar]

On the another hand, I like this changes, 👍

[nmccready]

BTW I thought the Babel compiled code to this was quite comical. As people who hate CoffeeScript babel's output is way way harder to read. I almost would rather revert this to ES5.

[nmccready]

https://github.com/realtymaps/ui-leaflet/blob/dev/nmccready/issue_105_leaflet_draw/dist/ui-leaflet.js#L5011-L5039

[nmccready]

vs

angular.module('ui-leaflet')
.factory 'leafletDrawEvents', (leafletEventsHelpersFactory) ->

  class DrawEvents extends leafletEventsHelpersFactory
    constructor: () ->
      super('leafletDirectiveDraw', 'draw')


    getAvailableEvents: () ->
      return [
        'created'
        'edited'
        'deleted'
        'drawstart'
        'drawstop'
        'editstart'
        'editstop'
        'deletestart'
        'deletestop'].map (n) -> 
          return 'draw:' + n

    new DrawEvents()

yeilds:

var extend = function(child, parent) { for (var key in parent) { if (hasProp.call(parent, key)) child[key] = parent[key]; } function ctor() { this.constructor = child; } ctor.prototype = parent.prototype; child.prototype = new ctor(); child.__super__ = parent.prototype; return child; },
  hasProp = {}.hasOwnProperty;

angular.module('ui-leaflet').factory('leafletDrawEvents', function(leafletEventsHelpersFactory) {
  var DrawEvents;
  return DrawEvents = (function(superClass) {
    extend(DrawEvents, superClass);

    function DrawEvents() {
      DrawEvents.__super__.constructor.call(this, 'leafletDirectiveDraw', 'draw');
    }

    DrawEvents.prototype.getAvailableEvents = function() {
      return ['created', 'edited', 'deleted', 'drawstart', 'drawstop', 'editstart', 'editstop', 'deletestart', 'deletestop'].map(function(n) {
        return 'draw:' + n;
      });
    };

    new DrawEvents();

    return DrawEvents;

  })(leafletEventsHelpersFactory);
});

// ---
// generated by coffee-script 1.9.2

[nmccready]

@elesdoar no, I need these changes now for work. Plus this is backwards compatible but done in a more modular way. I plan on switching the other directives to be like this as well with the angular.config.

[nmccready]

Note besides grunt karma you can run npm run karma now.

[nmccready]

I plan on having a follow up PR for documentation and more specs. As well as fixing directiveControls, and leafletData.

[nmccready]

@elesdoar your right, I will put all the leaflet draw stuff into a sep repo. This PR will become just karma, grunt, and babel fixes.

[nmccready]

Closing for plugin / component repo for ui-leaflet-draw.

https://github.com/angular-ui/ui-leaflet-draw