Skip to content
This repository was archived by the owner on Sep 20, 2019. It is now read-only.

issue 185 babel, karma, and indent fixes #187

Merged
merged 5 commits into from
Nov 9, 2015
Merged

issue 185 babel, karma, and indent fixes #187

merged 5 commits into from
Nov 9, 2015

Conversation

nmccready
Copy link
Contributor

  • Indenting fixed for files that were not 4 space indented.
  • keeping 4 spaces as editorconfig solves all headaches
  • babel / es6 added
  • karma simplified

@nmccready
fix(grunt, karma): huge glob would run out of memory. Removed
06657c9 
grunt-karma and fire up karma ourselves.

fix(karma): coverage fixed and coverage report breaks down source
mapping

chore(indent): indenting to 2

chore(es6): via babel
@nmccready
"chore(indenting): keeping indenting at 4 but enforcing it across other
7ed550e 
files. .editorconfig makes different types of indenting across projects
a mute point to fight about."
@nmccready
more indenting fixes
7483f6b
@nmccready
style(grunt aliases): yml to coffee
fd20843
@nmccready
gitignore logo.svg
2a83b1f
@nmccready
Copy link
Contributor Author

Basically this replaces #184 but decided to leave 4 space indenting.

@j-r-t
Copy link
Contributor

j-r-t commented Nov 9, 2015

LGTM

j-r-t added a commit that referenced this pull request Nov 9, 2015
@j-r-t
Merge pull request #187 from realtymaps/dev/nmccready/issue_185_babel…
7b0de23 
…_indent_karma

issue 185 babel, karma, and indent fixes
@j-r-t j-r-t merged commit 7b0de23 into angular-ui:master Nov 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmccready @j-r-t